Skip to content

Commit 92795ff

Browse files
authored
Show progress when reloading the Rails application (#563)
One of the slowest parts of DSL RBI generation in the Tapioca add-on is actually the fact that we're reloading the Rails app. In addition to adding progress notifications there, let's also show the progress of reloading the app, so that the user knows what's going on.
1 parent fe92358 commit 92795ff

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

lib/ruby_lsp/ruby_lsp_rails/server.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,8 +258,10 @@ def execute(request, params)
258258
send_result(run_migrations)
259259
end
260260
when "reload"
261-
with_notification_error_handling(request) do
262-
::Rails.application.reloader.reload!
261+
with_progress("rails-reload", "Reloading Ruby LSP Rails instance") do
262+
with_notification_error_handling(request) do
263+
::Rails.application.reloader.reload!
264+
end
263265
end
264266
when "route_location"
265267
with_request_error_handling(request) do

0 commit comments

Comments
 (0)