Improve some Rust tests

Author: adampetro

checkout/rust/cart-checkout-validation/default/src/tests.rs

@@ -2,7 +2,7 @@ use super::*;
 use shopify_function::{run_function_with_input, Result};
 
 #[test]
-fn test_result_contains_no_operations() -> Result<()> {
+fn test_result_contains_single_error_when_quantity_exceeds_one() -> Result<()> {
     let result = run_function_with_input(
         function,
         r#"
@@ -17,12 +17,34 @@ fn test_result_contains_no_operations() -> Result<()> {
             }
         "#,
     )?;
-    let mut errors = Vec::new();
-    errors.push(FunctionError {
-        localized_message: "Not possible to order more than one of each".to_owned(),
-        target: "cart".to_owned(),
-    });
-    let expected = crate::output::FunctionResult { errors: errors };
+    let expected = crate::output::FunctionResult {
+        errors: vec![FunctionError {
+            localized_message: "Not possible to order more than one of each".to_owned(),
+            target: "cart".to_owned(),
+        }],
+    };
+
+    assert_eq!(result, expected);
+    Ok(())
+}
+
+#[test]
+fn test_result_contains_no_errors_when_quantity_is_one() -> Result<()> {
+    let result = run_function_with_input(
+        function,
+        r#"
+            {
+                "cart": {
+                    "lines": [
+                        {
+                            "quantity": 1
+                        }
+                    ]
+                }
+            }
+        "#,
+    )?;
+    let expected = crate::output::FunctionResult { errors: vec![] };
 
     assert_eq!(result, expected);
     Ok(())

checkout/rust/cart-transform/default/src/main.rs

@@ -3,15 +3,18 @@ use shopify_function::Result;
 
 use serde::{Deserialize, Serialize};
 
+type URL = String;
+
 generate_types!(
     query_path = "./input.graphql",
     schema_path = "./schema.graphql"
 );
 
 #[shopify_function]
 fn function(input: input::ResponseData) -> Result<output::FunctionResult> {
-
-    let no_changes = output::FunctionResult { operations: Some(vec![]) };
+    let no_changes = output::FunctionResult {
+        operations: Some(vec![]),
+    };
 
     Ok(no_changes)
- }
+}

discounts/rust/order-discounts/default/src/tests.rs

@@ -13,8 +13,11 @@ fn test_result_contains_no_discounts() -> Result<()> {
             }
         "#,
     )?;
-    let expected = 0;
+    let expected = output::FunctionResult {
+        discounts: vec![],
+        discount_application_strategy: output::DiscountApplicationStrategy::FIRST,
+    };
 
-    assert_eq!(result.discounts.len(), expected);
+    assert_eq!(result, expected);
     Ok(())
 }

discounts/rust/product-discounts/default/src/tests.rs

@@ -13,8 +13,11 @@ fn test_result_contains_no_discounts() -> Result<()> {
             }
         "#,
     )?;
-    let expected = 0;
+    let expected = output::FunctionResult {
+        discounts: vec![],
+        discount_application_strategy: output::DiscountApplicationStrategy::FIRST,
+    };
 
-    assert_eq!(result.discounts.len(), expected);
+    assert_eq!(result, expected);
     Ok(())
 }

discounts/rust/shipping-discounts/default/src/tests.rs

@@ -13,8 +13,11 @@ fn test_result_contains_no_discounts() -> Result<()> {
             }
         "#,
     )?;
-    let expected = 0;
+    let expected = output::FunctionResult {
+        discounts: vec![],
+        discount_application_strategy: output::DiscountApplicationStrategy::FIRST,
+    };
 
-    assert_eq!(result.discounts.len(), expected);
+    assert_eq!(result, expected);
     Ok(())
 }