Skip to content

Commit ad934a8

Browse files
authored
Merge pull request #36 from ShipEngine/jpill/increase-default-timeout-to-60s
fix: change default timeout to 60s
2 parents d0b47db + 7969f00 commit ad934a8

File tree

5 files changed

+10
-4
lines changed

5 files changed

+10
-4
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,9 @@
66
### Bug Fixes
77

88
* Update publish to Gem API Key ([3f9c8e5](https://github.com/ShipEngine/shipengine-ruby/commit/3f9c8e5eec8147e2fb1b38a114fa0e2ff24a5f9e))
9+
10+
## [1.0.4]
11+
12+
### Changes
13+
14+
* increase default timeout from 30s to 60s

Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
PATH
22
remote: .
33
specs:
4-
shipengine_sdk (1.0.3)
4+
shipengine_sdk (1.0.4)
55
faraday (>= 1.4)
66
faraday_middleware (>= 1.0)
77
hashie (>= 3.4)

lib/shipengine/configuration.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ def initialize(api_key:, retries: nil, timeout: nil, page_size: nil, base_url: n
88
@api_key = api_key
99
@base_url = base_url || Constants.base_url
1010
@retries = retries || 1
11-
@timeout = timeout || 30_000
11+
@timeout = timeout || 60_000
1212
@page_size = page_size || 50
1313
validate
1414
end

lib/shipengine/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# frozen_string_literal: true
22

33
module ShipEngine
4-
VERSION = '1.0.3'
4+
VERSION = '1.0.4'
55
end

test/internal_client/configuration_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
client = ShipEngine::Client.new('foo')
1616

1717
# the global configuration should not be mutated
18-
assert_equal 30_000, client.configuration.timeout
18+
assert_equal 60_000, client.configuration.timeout
1919
assert_equal 50, client.configuration.page_size
2020
end
2121
it 'the global config should not be mutated if overridden at method call time' do

0 commit comments

Comments
 (0)