Skip to content
This repository was archived by the owner on Aug 24, 2025. It is now read-only.

Commit eae3a30

Browse files
committed
Merge commit '97c0959f27b294fe1eb10b547145ebef2524b896'
2 parents 0a8055f + 97c0959 commit eae3a30

File tree

282 files changed

+5193
-2132
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

282 files changed

+5193
-2132
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ Makefile
5151
/test/ssltest_old
5252
/test/x509aux
5353
/test/v3ext
54+
/test/versions
5455

5556
# Certain files that get created by tests on the fly
5657
/test/test-runs

.travis.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,15 +61,15 @@ matrix:
6161
sources:
6262
- ubuntu-toolchain-r-test
6363
compiler: gcc-5
64-
env: CONFIG_OPTS="no-asm enable-ubsan enable-rc5 enable-md2 -DPEDANTIC"
64+
env: UBUNTU_GCC_HACK="yes" CONFIG_OPTS="no-asm enable-ubsan enable-rc5 enable-md2 -DPEDANTIC"
6565
- os: linux
6666
addons:
6767
apt:
6868
packages:
6969
- binutils-mingw-w64
7070
- gcc-mingw-w64
7171
compiler: i686-w64-mingw32-gcc
72-
env: CONFIG_OPTS="no-pic" TESTS="-test_fuzz"
72+
env: CONFIG_OPTS="no-pic"
7373
- os: linux
7474
addons:
7575
apt:
@@ -85,7 +85,7 @@ matrix:
8585
- binutils-mingw-w64
8686
- gcc-mingw-w64
8787
compiler: x86_64-w64-mingw32-gcc
88-
env: CONFIG_OPTS="no-pic" TESTS="-test_fuzz"
88+
env: CONFIG_OPTS="no-pic"
8989
- os: linux
9090
addons:
9191
apt:
@@ -112,6 +112,10 @@ before_script:
112112
srcdir=.;
113113
top=.;
114114
fi
115+
- if [ -n "$UBUNTU_GCC_HACK" ]; then
116+
$CC -dumpspecs | sed "s/--push-state//g; s/--pop-state/--as-needed/g" > gcc-specs.txt;
117+
CC="$CC -specs=gcc-specs.txt";
118+
fi
115119
- if [ "$CC" == i686-w64-mingw32-gcc ]; then
116120
export CROSS_COMPILE=${CC%%gcc}; unset CC;
117121
$srcdir/Configure mingw $CONFIG_OPTS -Wno-pedantic-ms-format;
@@ -186,7 +190,7 @@ script:
186190
fi
187191
- if [ -n "$DESTDIR" ]; then
188192
mkdir "../$DESTDIR";
189-
if $make install install_docs DESTDIR="../$DESTDIR"; then
193+
if $make install DESTDIR="../$DESTDIR"; then
190194
echo -e '+\057\057\057\057\057 MAKE INSTALL_DOCS OK';
191195
else
192196
echo -e '+\057\057\057\057\057 MAKE INSTALL_DOCS FAILED'; false;

CHANGES

Lines changed: 75 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,81 @@
77
https://github.com/openssl/openssl/commits/ and pick the appropriate
88
release branch.
99

10+
Changes between 1.1.0h and 1.1.0i [14 Aug 2018]
11+
12+
*) Client DoS due to large DH parameter
13+
14+
During key agreement in a TLS handshake using a DH(E) based ciphersuite a
15+
malicious server can send a very large prime value to the client. This will
16+
cause the client to spend an unreasonably long period of time generating a
17+
key for this prime resulting in a hang until the client has finished. This
18+
could be exploited in a Denial Of Service attack.
19+
20+
This issue was reported to OpenSSL on 5th June 2018 by Guido Vranken
21+
(CVE-2018-0732)
22+
[Guido Vranken]
23+
24+
*) Cache timing vulnerability in RSA Key Generation
25+
26+
The OpenSSL RSA Key generation algorithm has been shown to be vulnerable to
27+
a cache timing side channel attack. An attacker with sufficient access to
28+
mount cache timing attacks during the RSA key generation process could
29+
recover the private key.
30+
31+
This issue was reported to OpenSSL on 4th April 2018 by Alejandro Cabrera
32+
Aldaya, Billy Brumley, Cesar Pereida Garcia and Luis Manuel Alvarez Tapia.
33+
(CVE-2018-0737)
34+
[Billy Brumley]
35+
36+
*) Make EVP_PKEY_asn1_new() a bit stricter about its input. A NULL pem_str
37+
parameter is no longer accepted, as it leads to a corrupt table. NULL
38+
pem_str is reserved for alias entries only.
39+
[Richard Levitte]
40+
41+
*) Revert blinding in ECDSA sign and instead make problematic addition
42+
length-invariant. Switch even to fixed-length Montgomery multiplication.
43+
[Andy Polyakov]
44+
45+
*) Change generating and checking of primes so that the error rate of not
46+
being prime depends on the intended use based on the size of the input.
47+
For larger primes this will result in more rounds of Miller-Rabin.
48+
The maximal error rate for primes with more than 1080 bits is lowered
49+
to 2^-128.
50+
[Kurt Roeckx, Annie Yousar]
51+
52+
*) Increase the number of Miller-Rabin rounds for DSA key generating to 64.
53+
[Kurt Roeckx]
54+
55+
*) Add blinding to ECDSA and DSA signatures to protect against side channel
56+
attacks discovered by Keegan Ryan (NCC Group).
57+
[Matt Caswell]
58+
59+
*) When unlocking a pass phrase protected PEM file or PKCS#8 container, we
60+
now allow empty (zero character) pass phrases.
61+
[Richard Levitte]
62+
63+
*) Certificate time validation (X509_cmp_time) enforces stricter
64+
compliance with RFC 5280. Fractional seconds and timezone offsets
65+
are no longer allowed.
66+
[Emilia Käsper]
67+
68+
*) Fixed a text canonicalisation bug in CMS
69+
70+
Where a CMS detached signature is used with text content the text goes
71+
through a canonicalisation process first prior to signing or verifying a
72+
signature. This process strips trailing space at the end of lines, converts
73+
line terminators to CRLF and removes additional trailing line terminators
74+
at the end of a file. A bug in the canonicalisation process meant that
75+
some characters, such as form-feed, were incorrectly treated as whitespace
76+
and removed. This is contrary to the specification (RFC5485). This fix
77+
could mean that detached text data signed with an earlier version of
78+
OpenSSL 1.1.0 may fail to verify using the fixed version, or text data
79+
signed with a fixed OpenSSL may fail to verify with an earlier version of
80+
OpenSSL 1.1.0. A workaround is to only verify the canonicalised text data
81+
and use the "-binary" flag (for the "cms" command line application) or set
82+
the SMIME_BINARY/PKCS7_BINARY/CMS_BINARY flags (if using CMS_verify()).
83+
[Matt Caswell]
84+
1085
Changes between 1.1.0g and 1.1.0h [27 Mar 2018]
1186

1287
*) Constructed ASN.1 types with a recursive definition could exceed the stack

CONTRIBUTING

Lines changed: 42 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,26 @@
1-
HOW TO CONTRIBUTE PATCHES TO OpenSSL
2-
------------------------------------
1+
HOW TO CONTRIBUTE TO OpenSSL
2+
----------------------------
33

44
(Please visit https://www.openssl.org/community/getting-started.html for
55
other ideas about how to contribute.)
66

7-
Development is coordinated on the openssl-dev mailing list (see the
8-
above link or https://mta.openssl.org for information on subscribing).
9-
If you are unsure as to whether a feature will be useful for the general
10-
OpenSSL community you might want to discuss it on the openssl-dev mailing
11-
list first. Someone may be already working on the same thing or there
12-
may be a good reason as to why that feature isn't implemented.
7+
Development is done on GitHub, https://github.com/openssl/openssl.
138

14-
To submit a patch, make a pull request on GitHub. If you think the patch
15-
could use feedback from the community, please start a thread on openssl-dev
16-
to discuss it.
9+
To request new features or report bugs, please open an issue on GitHub
1710

18-
Having addressed the following items before the PR will help make the
19-
acceptance and review process faster:
11+
To submit a patch, please open a pull request on GitHub. If you are thinking
12+
of making a large contribution, open an issue for it before starting work,
13+
to get comments from the community. Someone may be already working on
14+
the same thing or there may be reasons why that feature isn't implemented.
2015

21-
1. Anything other than trivial contributions will require a contributor
22-
licensing agreement, giving us permission to use your code. See
23-
https://www.openssl.org/policies/cla.html for details.
16+
To make it easier to review and accept your pull request, please follow these
17+
guidelines:
18+
19+
1. Anything other than a trivial contribution requires a Contributor
20+
License Agreement (CLA), giving us permission to use your code. See
21+
https://www.openssl.org/policies/cla.html for details. If your
22+
contribution is too small to require a CLA, put "CLA: trivial" on a
23+
line by itself in your commit message body.
2424

2525
2. All source files should start with the following text (with
2626
appropriate comment characters at the start of each line and the
@@ -34,21 +34,38 @@ acceptance and review process faster:
3434
https://www.openssl.org/source/license.html
3535

3636
3. Patches should be as current as possible; expect to have to rebase
37-
often. We do not accept merge commits; You will be asked to remove
38-
them before a patch is considered acceptable.
37+
often. We do not accept merge commits, you will have to remove them
38+
(usually by rebasing) before it will be acceptable.
3939

4040
4. Patches should follow our coding style (see
41-
https://www.openssl.org/policies/codingstyle.html) and compile without
42-
warnings. Where gcc or clang is available you should use the
41+
https://www.openssl.org/policies/codingstyle.html) and compile
42+
without warnings. Where gcc or clang is available you should use the
4343
--strict-warnings Configure option. OpenSSL compiles on many varied
44-
platforms: try to ensure you only use portable features.
45-
Clean builds via Travis and AppVeyor are expected, and done whenever
46-
a PR is created or updated.
44+
platforms: try to ensure you only use portable features. Clean builds
45+
via Travis and AppVeyor are required, and they are started automatically
46+
whenever a PR is created or updated.
4747

4848
5. When at all possible, patches should include tests. These can
4949
either be added to an existing test, or completely new. Please see
5050
test/README for information on the test framework.
5151

5252
6. New features or changed functionality must include
53-
documentation. Please look at the "pod" files in doc/apps, doc/crypto
54-
and doc/ssl for examples of our style.
53+
documentation. Please look at the "pod" files in doc for
54+
examples of our style.
55+
56+
7. For user visible changes (API changes, behaviour changes, ...),
57+
consider adding a note in CHANGES. This could be a summarising
58+
description of the change, and could explain the grander details.
59+
Have a look through existing entries for inspiration.
60+
Please note that this is NOT simply a copy of git-log oneliners.
61+
Also note that security fixes get an entry in CHANGES.
62+
This file helps users get more in depth information of what comes
63+
with a specific release without having to sift through the higher
64+
noise ratio in git-log.
65+
66+
8. For larger or more important user visible changes, as well as
67+
security fixes, please add a line in NEWS. On exception, it might be
68+
worth adding a multi-line entry (such as the entry that announces all
69+
the types that became opaque with OpenSSL 1.1.0).
70+
This file helps users get a very quick summary of what comes with a
71+
specific release, to see if an upgrade is worth the effort.

0 commit comments

Comments
 (0)