Task/add sensor metadata #31

SelahattinSert · 2024-12-08T23:45:46Z

Implementation of Sensor Metadata Management and Services for Cameras without unit tests.

ozgen

I revewed your changes @SelahattinSert , I didnt want to write duplicate comments fyi...

src/main/java/com/onboarding/camera/cameraonboarding/entity/Sensor.java

src/main/java/com/onboarding/camera/cameraonboarding/controller/LightSensorController.java

src/main/java/com/onboarding/camera/cameraonboarding/converter/SensorDtoConverter.java

src/main/java/com/onboarding/camera/cameraonboarding/service/impl/LightSensorService.java

src/main/java/com/onboarding/camera/cameraonboarding/service/impl/MotionSensorService.java

ozgen

I added few comments @SelahattinSert

src/main/java/com/onboarding/camera/cameraonboarding/service/impl/LightSensorService.java

src/main/java/com/onboarding/camera/cameraonboarding/service/impl/MotionSensorService.java

src/main/java/com/onboarding/camera/cameraonboarding/service/impl/TemperatureSensorService.java

src/main/java/com/onboarding/camera/cameraonboarding/entity/Camera.java

src/main/java/com/onboarding/camera/cameraonboarding/controller/LightSensorController.java

src/main/java/com/onboarding/camera/cameraonboarding/controller/MotionSensorController.java

...main/java/com/onboarding/camera/cameraonboarding/controller/TemperatureSensorController.java

…orkflow changes

ozgen

I added some comments @SelahattinSert

src/main/java/com/onboarding/camera/cameraonboarding/service/impl/LightSensorService.java

src/main/java/com/onboarding/camera/cameraonboarding/service/impl/MotionSensorService.java

src/main/java/com/onboarding/camera/cameraonboarding/service/impl/TemperatureSensorService.java

SelahattinSert · 2024-12-23T21:52:19Z

I applied your advise for instanceof @ozgen

ozgen

looks good to me, you can start working on the unit tests @SelahattinSert

SelahattinSert · 2024-12-27T18:45:57Z

I initially added light sensor tests if it is ok then i will add other sensor tests. is it ok? @ozgen

ozgen

I added few comments @SelahattinSert

src/test/java/com/onboarding/camera/cameraonboarding/controller/LightSensorControllerTest.java

src/test/java/com/onboarding/camera/cameraonboarding/converter/SensorDtoConverterTest.java

src/test/java/com/onboarding/camera/cameraonboarding/repository/LightSensorRepositoryTest.java

src/test/java/com/onboarding/camera/cameraonboarding/service/impl/LightSensorServiceTest.java

ozgen

i added few comments @SelahattinSert

src/test/java/com/onboarding/camera/cameraonboarding/controller/LightSensorControllerTest.java

src/test/java/com/onboarding/camera/cameraonboarding/converter/SensorDtoConverterTest.java

src/test/java/com/onboarding/camera/cameraonboarding/repository/LightSensorRepositoryTest.java

ozgen

looks good to me, you can write motion and temperature sensor unit tests
@SelahattinSert

ozgen

looks good to me and you can merge your pull request @SelahattinSert

ozgen · 2025-01-05T18:51:28Z

i think these issues are enough for coding and i will create a ticket for devops topic @SelahattinSert

SelahattinSert · 2025-01-05T19:56:03Z

sure @ozgen

SelahattinSert added 13 commits December 9, 2024 02:24

Include db changelog v3

0cdd9fe

Add sensor_metadata liquibase changelog

cc2ab2d

Add sensor entities

920ae1b

Add SensorType enum

e91bb23

Add sensor exceptions

a4f0f67

Add sensor repositories

25acda8

Add sensor service

80e105d

Add sensor service implementations

167dd8b

Add sensor dto

8e23d30

Add sensor response

2ee497a

Add sensor dto converter

9f3e26b

Add sensor exception handler methods

ecc1cda

Add sensor REST controllers

3ae6b1a

SelahattinSert requested a review from ozgen December 8, 2024 23:46

SelahattinSert self-assigned this Dec 8, 2024

ozgen requested changes Dec 12, 2024

View reviewed changes

SelahattinSert added 10 commits December 14, 2024 14:46

Include changelog v3

ae5d91b

Remove redundant exception handling

0b2c00d

Refactor service methods

5012b03

Refactor repository

37e3f5a

Add enum explanation

ed39154

Add sensors list to camera entity

973954c

Add toString annotation

0a42b37

Add toString annotation

7298ae8

Refactor conversion methods

15483c0

Remove redundant path variable

71eceac

SelahattinSert requested a review from ozgen December 14, 2024 12:13

ozgen requested changes Dec 15, 2024

View reviewed changes

SelahattinSert and others added 2 commits December 19, 2024 12:49

Merge branch 'master' into 'task/add-sensor-metadata' to include CI w…

6531381

…orkflow changes

Include db changelog v3

961d86c

SelahattinSert requested a review from ozgen December 20, 2024 00:35

ozgen requested changes Dec 22, 2024

View reviewed changes

Refactor sensor receive method

9f013e5

SelahattinSert requested a review from ozgen December 23, 2024 21:51

ozgen reviewed Dec 23, 2024

View reviewed changes

SelahattinSert added 2 commits December 27, 2024 21:42

Add sensor dto converter unit test

38f15be

Add light sensor unit and integration tests

8bff631

SelahattinSert requested a review from ozgen December 27, 2024 18:46

ozgen requested changes Dec 27, 2024

View reviewed changes

SelahattinSert added 3 commits December 29, 2024 20:05

Add sensor dto validation method

33d39d6

Add test cases for invalid data

402a178

Fix sensor test methods

914a5c1

SelahattinSert requested a review from ozgen December 29, 2024 17:10

ozgen requested changes Dec 30, 2024

View reviewed changes

SelahattinSert added 3 commits January 2, 2025 01:54

Remove unused import

e9dd43a

Add new test cases

fe79fcf

Fix test methods

7529618

SelahattinSert requested a review from ozgen January 1, 2025 23:34

ozgen reviewed Jan 3, 2025

View reviewed changes

SelahattinSert added 3 commits January 4, 2025 02:59

Add motion and temperature sensor controller tests

01d7d73

Add motion and temperature sensor repository tests

131ee0d

Add motion and temperature sensor service tests

f297971

SelahattinSert requested a review from ozgen January 4, 2025 00:04

ozgen approved these changes Jan 5, 2025

View reviewed changes

SelahattinSert merged commit bcd0091 into master Jan 5, 2025
1 check passed

SelahattinSert deleted the task/add-sensor-metadata branch January 5, 2025 19:56

Task/add sensor metadata #31

Task/add sensor metadata #31

Uh oh!

Conversation

SelahattinSert commented Dec 8, 2024

Uh oh!

ozgen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ozgen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ozgen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SelahattinSert commented Dec 23, 2024

Uh oh!

ozgen left a comment

Choose a reason for hiding this comment

Uh oh!

SelahattinSert commented Dec 27, 2024

Uh oh!

ozgen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ozgen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ozgen left a comment

Choose a reason for hiding this comment

Uh oh!

ozgen left a comment

Choose a reason for hiding this comment

Uh oh!

ozgen commented Jan 5, 2025

Uh oh!

SelahattinSert commented Jan 5, 2025

Uh oh!