Merge branch 'do/eisenstat-walker' of github.com:termi-official/NonlinearSolve.jl into do/eisenstat-walker

Author: termi-official

.github/workflows/CompatHelper.yml

@@ -15,7 +15,7 @@ jobs:
         julia-arch: [x86]
         os: [ubuntu-latest]
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - uses: julia-actions/setup-julia@latest
         with:
           version: ${{ matrix.julia-version }}

.github/workflows/Documentation.yml

@@ -12,7 +12,7 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - uses: julia-actions/setup-julia@v2
         with:
           version: "1"

.github/workflows/Downstream.yml

@@ -29,7 +29,7 @@ jobs:
           - {user: SciML, repo: BoundaryValueDiffEq.jl, group: All}
           - {user: SciML, repo: DiffEqCallbacks.jl, group: Core}
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - uses: julia-actions/setup-julia@v2
         with:
           version: ${{ matrix.julia-version }}
@@ -47,7 +47,7 @@ jobs:
           Pkg.instantiate()
         shell: julia --color=yes --code-coverage=user --depwarn=yes --project=. {0}
       - name: Clone Downstream
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6
         with:
           repository: ${{ matrix.package.user }}/${{ matrix.package.repo }}
           path: downstream

.github/workflows/SpellCheck.yml

@@ -8,6 +8,6 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout Actions Repository
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6
       - name: Check spelling
         uses: crate-ci/typos@v1.18.0 

README.md

@@ -26,7 +26,7 @@ using NonlinearSolve, StaticArrays
 f(u, p) = u .* u .- 2
 u0 = @SVector[1.0, 1.0]
 prob = NonlinearProblem(f, u0)
-solver = solve(prob)
+sol = solve(prob)
 
 ## Bracketing Methods
 

lib/NonlinearSolveBase/src/solve.jl

@@ -151,11 +151,8 @@ function solve_call(_prob, args...; merge_callbacks = true, kwargshandle = nothi
                 throw(NonConcreteEltypeError(RecursiveArrayTools.recursive_unitless_eltype(_prob.u0)))
             end
 
-            if !(eltype(_prob.u0) <: Number) && !(eltype(_prob.u0) <: Enum) &&
-               !(_prob.u0 isa AbstractVector{<:AbstractArray} && _prob isa BVProblem)
-                # Allow Enums for FunctionMaps, make into a trait in the future
-                # BVPs use Vector of Arrays for initial guesses
-                throw(NonNumberEltypeError(eltype(_prob.u0)))
+            if !(eltype(_prob.u0) <: Number) && !(eltype(_prob.u0) <: Enum)
+                throw(SciMLBase.NonNumberEltypeError(eltype(_prob.u0)))
             end
         end
 

test/core_tests.jl

@@ -444,3 +444,10 @@ end
     sol = solve(prob)
     @test SciMLBase.successful_retcode(sol)
 end
+
+@testitem "NonNumberEltype error" tags=[:core] begin
+    u0_broken = [rand(2), rand(2)]
+    f(u,p) = u
+    prob = NonlinearProblem(f, u0_broken)
+    @test_throws SciMLBase.NonNumberEltypeError solve(prob)
+end