Skip to content

Commit 1ff888f

Browse files
Remove export of helper constructor
1 parent 5aef765 commit 1ff888f

File tree

3 files changed

+2
-29
lines changed

3 files changed

+2
-29
lines changed

lib/NonlinearSolveFirstOrder/src/NonlinearSolveFirstOrder.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ end
100100
@reexport using SciMLBase, NonlinearSolveBase
101101

102102
export NewtonRaphson, PseudoTransient
103-
export EisenstatWalkerNewtonKrylov
104103
export GaussNewton, LevenbergMarquardt, TrustRegion
105104

106105
export RadiusUpdateSchemes

lib/NonlinearSolveFirstOrder/src/eisenstat_walker.jl

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -97,29 +97,3 @@ function InternalAPI.reinit!(
9797
)
9898
cache.p = p
9999
end
100-
101-
102-
103-
"""
104-
EisenstatWalkerNewtonKrylov(;
105-
concrete_jac = nothing, linsolve = nothing, linesearch = missing,
106-
autodiff = nothing, vjp_autodiff = nothing, jvp_autodiff = nothing
107-
)
108-
109-
An advanced Newton-Krylov implementation with support for efficient handling of sparse
110-
matrices via colored automatic differentiation and preconditioned linear solvers. Designed
111-
for large-scale and numerically-difficult nonlinear systems.
112-
"""
113-
function EisenstatWalkerNewtonKrylov(;
114-
concrete_jac = nothing, linsolve::LinearSolve.AbstractKrylovSubspaceMethod, linesearch = nothing,
115-
autodiff = nothing, vjp_autodiff = nothing, jvp_autodiff = nothing, forcing = EisenstatWalkerForcing2(),
116-
)
117-
return GeneralizedFirstOrderAlgorithm(;
118-
linesearch,
119-
descent = NewtonDescent(; linsolve),
120-
autodiff, vjp_autodiff, jvp_autodiff,
121-
concrete_jac,
122-
forcing,
123-
name = :EisenstatWalkerNewtonKrylov
124-
)
125-
end

lib/NonlinearSolveFirstOrder/test/rootfind_tests.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ end
2525
),
2626
)
2727
@testset "[OOP] u0: $(typeof(u0))" for u0 in u0s
28-
solver = EisenstatWalkerNewtonKrylov(; linsolve, concrete_jac)
28+
solver = NewtonKrylov(; forcing=EisenstatWalkerForcing2(), linsolve, concrete_jac)
2929
sol = solve_oop(quadratic_f, u0; solver)
3030
@test SciMLBase.successful_retcode(sol)
3131
err = maximum(abs, quadratic_f(sol.u, 2.0))
@@ -38,7 +38,7 @@ end
3838
end
3939

4040
@testset "[IIP] u0: $(typeof(u0))" for u0 in ([1.0, 1.0],)
41-
solver = EisenstatWalkerNewtonKrylov(; linsolve, concrete_jac)
41+
solver = NewtonKrylov(; forcing=EisenstatWalkerForcing2(), linsolve, concrete_jac)
4242

4343
sol = solve_iip(quadratic_f!, u0; solver)
4444
@test SciMLBase.successful_retcode(sol)

0 commit comments

Comments
 (0)