Deprecate fastindices. Closes #80

Author: jonniedie

src/ComponentArrays.jl

@@ -9,20 +9,32 @@ const FlatOrColonIdx = Union{FlatIdx, Colon}
 
 
 include("utils.jl")
+export fastindices
+
 include("lazyarray.jl")
+
 include("axis.jl")
+export AbstractAxis, Axis, PartitionedAxis, ShapedAxis, ViewAxis, FlatAxis
+
 include("componentindex.jl")
+
 include("componentarray.jl")
+export ComponentArray, ComponentVector, ComponentMatrix, getaxes, getdata, valkeys
+
 include("set_get.jl")
+
 include("similar_convert_copy.jl")
+
 include("broadcasting.jl")
+
 include("math.jl")
+
 include("show.jl")
+
 include("plot_utils.jl")
-# include(joinpath("if_required", "chainrulescore.jl"))
+export labels, label2index
+
 
-# If using for differential equations, the Array(sol) overload in RecursiveArrayTools will
-# concatenate the ComponentVectors while preserving their ComponentArrayness
 required(filename) = include(joinpath("if_required", filename))
 
 function __init__()
@@ -33,16 +45,8 @@ function __init__()
     @require SciMLBase="0bca4576-84f4-4d90-8ffe-ffa030f20462" required("scimlbase.jl")
     @require RecursiveArrayTools="731186ca-8d62-57ce-b412-fbd966d074cd" required("recursivearraytools.jl")
     @require StaticArrays="90137ffa-7385-5640-81b9-e52037218182" required("staticarrays.jl")
-    # @require Zygote="e88e6eb3-aa80-5325-afca-941959d7151f" required("zygote.jl")
     @require ChainRulesCore="d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4" required("chainrulescore.jl")
     @require ReverseDiff="37e2e3b7-166d-5795-8a7a-e32c996b4267" required("reversediff.jl")
 end
 
-
-export AbstractAxis, Axis, PartitionedAxis, ShapedAxis, ViewAxis, FlatAxis
-
-export ComponentArray, ComponentVector, ComponentMatrix
-
-export getdata, getaxes, fastindices, labels, label2index, valkeys
-
 end

src/utils.jl

@@ -1,41 +1,5 @@
-"""
-    fastindices(i...)
-
-Wrap ```ComponentArray``` symbolic indices in ```Val```s for type-stable indexing.
-
-# Examples
-```julia-repl
-julia> using ComponentArrays
-
-julia> ca = ComponentArray(a=1, b=[2, 1, 4], c=(a=2, b=[1, 2]))
-ComponentVector{Int64}(a = 1, b = [2, 1, 4], c = (a = 2, b = [1, 2]))
-
-julia> ca2 = ca .* ca'
-7×7 ComponentMatrix{Int64} with axes Axis(a = 1, b = 2:4, c = ViewAxis(5:7, Axis(a = 1, b = 2:3))) × Axis(a = 1, b = 2:4, c = ViewAxis(5:7, Axis(a = 1, b = 2:3)))
- 1  2  1   4  2  1  2
- 2  4  2   8  4  2  4
- 1  2  1   4  2  1  2
- 4  8  4  16  8  4  8
- 2  4  2   8  4  2  4
- 1  2  1   4  2  1  2
- 2  4  2   8  4  2  4
-
-julia> _a, _b, _c = fastindices(:a, :b, :c)
-(Val{:a}(), Val{:b}(), Val{:c}())
-
-julia> ca2[_c, _c]
-3×3 ComponentMatrix{Int64,SubArray...} with axes Axis(a = 1, b = 2:3) × Axis(a = 1, b = 2:3)
- 4  2  4
- 2  1  2
- 4  2  4
-
-julia> ca2[_c, _c] == ca2[:c, :c]
-true
-```
-"""
-fastindices(i...) = toval.(i)
-fastindices(i::Tuple) = toval.(i)
-
+@deprecate fastindices(i::Tuple) Val.(i)
+@deprecate fastindices(i...) Val.((i...,))
 
 # Make a Val if input isn't already one
 toval(x::Val) = x