Skip to content

Fix the way scrolledToBottom directive calculates when to emit #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix the way scrolledToBottom directive calculates when to emit #1170

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c85921
fix detection calcuations
Sep 13, 2023
d189bfe
improve scrolled to bottom
Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/ng-sq-common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@sq-ui/ng-sq-common",
"version": "2.0.1",
"version": "2.0.2",
"license": "MIT",
"private": false,
"description": "The core module for SQ-UI kit for Angular",
Expand Down
3 changes: 2 additions & 1 deletion projects/ng-sq-common/src/lib/directives/scrolled-to-bottom-listener.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ export class ScrolledToBottomListenerDirective implements OnDestroy {
}

checkIfHasScrolledToBottom(element: HTMLElement) {
const hasScrolledToBottom = element.scrollTop > 0 ? ((element.scrollHeight - element.scrollTop) === element.clientHeight) : false;
const hasScrolledToBottom = element.scrollTop > 0 ?
(Math.ceil(element.scrollHeight - element.scrollTop) <= element.clientHeight) : false;

if (hasScrolledToBottom) {
this.scrolledToBottom.emit();
Expand Down