React/topic #47
Merged
React/topic #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@SergioRibera do you remember where is this component used? I don't see it in the roadmap site. |
Member
|
@Brayan-724 here usually to track the progress |
Brayan-724
approved these changes
Jun 26, 2025
styles/components/topic.css
Outdated
|
|
||
| .rustlanges-topic__summary { | ||
| @apply grid w-full grid-cols-[auto_1fr_auto_auto] items-center gap-2 border-y border-black px-3 py-4; | ||
| @apply [&>svg]:duration-400 [&>svg]:size-6 [&>svg]:transition; |
Member
There was a problem hiding this comment.
When a variant is used frequently I prefer to use the @variant at-rule, but in this case the css nesting is better like
& > svg {
@apply ...;
}
Member
There was a problem hiding this comment.
I know that in the current components this variant is used a lot but we should fix it, as this is a new component I think is good to set the guidelines.
Member
|
@SergioRibera that component is #16. This is another component but I didn't find where is used |
Brayan-724
reviewed
Jun 26, 2025
Closed
Brayan-724
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Related to #17
Summary
Interactive Topic dropdown
Details
Type and lint safe (check:tsc & -r lint)
Integrated into showcase/App.tsx
Screenshots