usb: typec: ucsi: Fix the return value of ucsi_run_command()

Heikki Krogerus · gregkh · commit d209d1634e65 · 2024-08-13T10:26:45.000+02:00
The command execution routines need to return the amount of data that was transferred when succesful. This fixes an issue where the alternate modes and the power delivery capabilities are not getting registered. Fixes: 5e9c166 ("usb: typec: ucsi: rework command execution functions") Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Link: https://lore.kernel.org/r/20240809150343.286942-1-heikki.krogerus@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
@@ -137,7 +137,7 @@ static int ucsi_run_command(struct ucsi *ucsi, u64 command, u32 *cci,
 	if (ret)
 		return ret;
 
-	return err;
+	return err ?: UCSI_CCI_LENGTH(*cci);
 }
 
 static int ucsi_read_error(struct ucsi *ucsi, u8 connector_num)

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,7 @@ static int ucsi_run_command(struct ucsi ucsi, u64 command, u32 cci,`
`137`	`137`	`if (ret)`
`138`	`138`	`return ret;`
`139`	`139`
`140`		`- return err;`
	`140`	`+ return err ?: UCSI_CCI_LENGTH(*cci);`
`141`	`141`	`}`
`142`	`142`
`143`	`143`	`static int ucsi_read_error(struct ucsi *ucsi, u8 connector_num)`