niu: Fix missing unwind goto in niu_alloc_channels()

harshimogalapalli · davem330 · commit 8ce07be70345 · 2023-04-07T08:17:54.000+01:00
Smatch reports: drivers/net/ethernet/sun/niu.c:4525 niu_alloc_channels() warn: missing unwind goto? If niu_rbr_fill() fails, then we are directly returning 'err' without freeing the channels. Fix this by changing direct return to a goto 'out_err'. Fixes: a3138df ("[NIU]: Add Sun Neptune ethernet driver.") Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> Reviewed-by: Simon Horman <simon.horman@corigine.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c
@@ -4522,7 +4522,7 @@ static int niu_alloc_channels(struct niu *np)
 
 		err = niu_rbr_fill(np, rp, GFP_KERNEL);
 		if (err)
-			return err;
+			goto out_err;
 	}
 
 	tx_rings = kcalloc(num_tx_rings, sizeof(struct tx_ring_info),

Original file line number	Diff line number	Diff line change
`@@ -4522,7 +4522,7 @@ static int niu_alloc_channels(struct niu *np)`
`4522`	`4522`
`4523`	`4523`	`err = niu_rbr_fill(np, rp, GFP_KERNEL);`
`4524`	`4524`	`if (err)`
`4525`		`- return err;`
	`4525`	`+ goto out_err;`
`4526`	`4526`	`}`
`4527`	`4527`
`4528`	`4528`	`tx_rings = kcalloc(num_tx_rings, sizeof(struct tx_ring_info),`