[BUG] In Windows command environment, execution fails with &&

[csg2008]

Problem (one or two sentences)

The command generated with&&resulted in execution failure, operating system Window 10, command content:

cd e:/Python/workspace/ocr/test && python -c "
import sys
import traceback
try:
    from svtr import test_svtrv2_onnx
    result = test_svtrv2_onnx('tiny', (1, 3, 32, 128), 'test_svtrv2.onnx')
    print(f'Result: {result}')
except Exception as e:
    print(f'Error: {e}')
    traceback.print_exc()
"

output:

所在位置 行:1 字符: 33
+ cd e:/Python/workspace/ocr/test && python -c "
+                                 ~~
标记“&&”不是此版本中的有效语句分隔符。
    + CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : InvalidEndOfLine

Context (who is affected and when)

In code mode, this error is encountered when roo code executes commands

Reproduction steps

1）Environment:
OS: Windows 10
IDE: vscode 1.106.3
Roo code: v3.36.2
Python: miniconda3 & python 3.12.11
2) none action
3) error output:

(py312) PS E:\Python\workspace\ocr\test> cd e:/Python/workspace/ocr/test && python -c "
>> import sys
>> import traceback
>> try:
>>     from svtr import test_svtrv2_onnx
>>     result = test_svtrv2_onnx('tiny', (1, 3, 32, 128), 'test_svtrv2.onnx')
>>     print(f'Result: {result}')
>> except Exception as e:
>>     print(f'Error: {e}')
>>     traceback.print_exc()
>> "
所在位置 行:1 字符: 33
+ cd e:/Python/workspace/ocr/test && python -c "
+                                 ~~
标记“&&”不是此版本中的有效语句分隔符。
    + CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : InvalidEndOfLine

Expected result

Independently execute multiple commands connected to&&

Actual result

Directly execute command, execution failed

Variations tried (optional)

No response

App Version

v3.36.2

API Provider (optional)

Not Applicable / Other

Model Used (optional)

kimi-for-coding

Roo Code Task Links (optional)

No response

Relevant logs or errors (optional)

(py312) PS E:\Python\workspace\ocr\test> cd e:/Python/workspace/ocr/test && python -c "from svtr import test_svtrv2_onnx; test_svtrv2_onnx('tiny', (1, 3, 32, 128), 'test_svtrv2.onnx')"
所在位置 行:1 字符: 33
+ cd e:/Python/workspace/ocr/test && python -c "from svtr import test_s ...
+                                 ~~
标记“&&”不是此版本中的有效语句分隔符。
    + CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
 
(py312) PS E:\Python\workspace\ocr\test> cd e:/Python/workspace/ocr/test && python -c "
>> import sys
>> import traceback
>> try:
>>     from svtr import test_svtrv2_onnx
>>     result = test_svtrv2_onnx('tiny', (1, 3, 32, 128), 'test_svtrv2.onnx')
>>     print(f'Result: {result}')
>> except Exception as e:
>>     print(f'Error: {e}')
>>     traceback.print_exc()
>> "
所在位置 行:1 字符: 33
+ cd e:/Python/workspace/ocr/test && python -c "
+                                 ~~
标记“&&”不是此版本中的有效语句分隔符。
    + CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : InvalidEndOfLine

[roomote]

I'm analyzing this issue. The problem is that Windows PowerShell doesn't recognize && as a valid command separator, unlike Unix shells. I'll explore the codebase to understand how commands are currently executed and propose a solution to handle Windows PowerShell properly.

[roomote]

I've analyzed this issue and here's my proposed implementation plan:

Problem Analysis

The issue occurs because Windows PowerShell doesn't recognize && as a valid command separator. PowerShell uses different operators:

• ; for sequential command execution (always runs next command)
• -and for logical AND in conditional expressions
• PowerShell 7+ supports && but Windows 10 typically ships with PowerShell 5.1 which doesn't

Proposed Solution

Transform command separators when executing in PowerShell to use PowerShell-compatible syntax:

1. Detect PowerShell environment - Already done in TerminalProcess.ts:112-116

2. Transform command separators in TerminalProcess.ts:

   • Replace && with ; if ($?) { ... } pattern (runs next command only if previous succeeded)
   • Replace || with ; if (-not $?) { ... } pattern (runs next command only if previous failed)
   • Handle nested command chains properly

3. Add comprehensive tests for the PowerShell command transformation logic

4. Preserve original behavior for non-PowerShell shells (bash, zsh, cmd.exe, etc.)

Implementation Details

The transformation will be applied in the PowerShell-specific block at TerminalProcess.ts:117-133 before executing the command. This ensures:

• Commands work correctly on Windows PowerShell 5.1
• No impact on other shells or platforms
• Maintains command execution semantics (conditional execution based on success/failure)

Example Transformation

Input: cd /path && python script.py
Output for PowerShell: cd /path; if ($?) { python script.py }

This approach will fix the issue while maintaining backward compatibility and correct command execution semantics.

Please mention @roomote in a comment saying that you approve this plan, and I'll proceed with the implementation.