[BUG] RooMote can't "approve" an action that was waiting for approval.

[dcbartlett]

Problem (one or two sentences)

RooMote can't "approve" an action that was waiting for approval in the extension before RooMote Control was activated. If you "Approve" the action in the extension, then RooMote continues to function as expected.

Context (who is affected and when)

Affects Users wanting to approve an action in roomote.

Reproduction steps

1. Start a task
2. Wait for it to ask for approval for something
3. Go to the task in roocode.com and enable roomote for the task
4. Notice the approve button and click it.
5. Click it again...
6. Get frustrated and Click Approve in VSCode Extension
7. Blink as RooMote works now.

Expected result

Approve to just "work" on the first try after enabling roomote control.

Actual result

Approve does not actually approve the action if it was initiated before roomote control was activated.

Variations tried (optional)

No response

App Version

Roo-Code-Nightly Version: 0.0.7421 (d285d01)

API Provider (optional)

Not Applicable / Other

Model Used (optional)

Opus 4.5

Roo Code Task Links (optional)

https://app.roocode.com/task/6a156b8c-05bb-496c-a78c-b258282673a0

Relevant logs or errors (optional)

[roomote]

I'm exploring this issue where RooMote cannot approve actions that were already waiting for approval before RooMote Control was activated. I'll analyze the codebase to understand the approval mechanism and propose a solution.

[roomote]

I've analyzed this issue and here's my proposed implementation plan:

Problem Analysis

When RooMote Control is activated for a task that already has a pending approval request, the approval mechanism doesn't work properly. The issue occurs because:

1. The task's ask() method is waiting for askResponse to be set via handleWebviewAskResponse()
2. When RooMote sends an approval command through TaskChannel, it calls task.approveAsk()
3. However, if the ask was initiated before RooMote was connected, the approval doesn't properly resolve the pending promise

Proposed Solution

Modify the approval flow in Task.ts to handle pre-existing approval requests:

1. In the ask() method (~line 1046-1170):

   • Add a check to see if there's already a pending response when RooMote approval comes in
   • Ensure the pWaitFor condition properly detects when askResponse is set by RooMote

2. In the approveAsk() and denyAsk() methods (~line 1203-1209):

   • These methods already call handleWebviewAskResponse(), but we need to ensure they trigger the resolution of any pending ask() promise
   • May need to add a notification mechanism or ensure the state change is properly detected

3. Add synchronization logic:

   • When RooMote control is activated mid-task, check if there's a pending ask
   • If so, ensure the task state is properly synchronized so RooMote approvals work immediately

Implementation Details

The fix will primarily involve:

• Ensuring this.askResponse is properly set when approveAsk() is called via RooMote
• Making sure the pWaitFor condition in ask() properly detects the state change
• Potentially adding a flag to track if an ask is pending and needs RooMote synchronization

This approach will allow RooMote to approve actions that were initiated before it was activated, fixing the user experience issue described.

Please mention @roomote in a comment saying that you approve this plan, and I'll proceed with the implementation.