Skip to content

Conversation

@RobinTail
Copy link
Owner

@RobinTail RobinTail commented Nov 10, 2025

Includes:

Summary by CodeRabbit

  • Chores

    • Switched build/test/CI tooling from tsx to unrun across the project and updated dev dependencies accordingly.
    • Added development utilities (compression, express-fileupload, typescript, zod).
    • Updated workspace configuration, removed certain build exclusions, and added dependency overrides.
  • Tests

    • Adjusted a test expectation to accommodate a minor formatting change in an error message.

✏️ Tip: You can customize this high-level summary in your review settings.

@RobinTail RobinTail added dependencies Pull requests that update a dependency file CI/CD labels Nov 10, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 10, 2025

Walkthrough

Replaced tsx with unrun across CI workflows, test specs, package scripts, and workspace config; removed tsx from devDependencies and added unrun; added devDependencies in example/package.json; minor test expectation formatting change.

Changes

Cohort / File(s) Summary
CI / Workflow
/.github/workflows/headers.yml
Replaced pnpm tsx tools/headers.ts with pnpm unrun tools/headers.ts.
Test specs
compat-test/quick-start.spec.ts, esm-test/quick-start.spec.ts, example/index.spec.ts
Swapped spawned runtime from tsx to unrun for example/test scripts.
Example package
example/package.json
Replaced tsx with unrun in start, build:docs, build:client; added devDependencies compression, express-fileupload, typescript, zod.
Root package
package.json
Replaced tsx with unrun in prebuild/pretest scripts; removed tsx from devDependencies; added unrun@^0.2.17.
Workspace config
pnpm-workspace.yaml
Removed esbuild from onlyBuiltDependencies; removed tsx from minimumReleaseAgeExclude; added overrides for lightningcss and vite.
Test expectation
express-zod-api/tests/common-helpers.spec.ts
Adjusted expected function formatting from multi-line to single-line () => {}.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Review attention:
    • Confirm unrun invocation and flags match prior tsx behavior in scripts/tools (headers, make-tests, contributors/license).
    • Validate added devDependencies in example/package.json and potential type/tooling implications.
    • Verify pnpm workspace overrides (vite, lightningcss) and removal of entries (esbuild, tsx) are intended and do not break builds.
    • Ensure the test expectation formatting change is stable across environments.

Possibly related PRs

Suggested labels

external bug

Poem

🐇 I swapped my boots from tsx to unrun today,
Hopped through scripts and tests along the way.
New deps in the burrow, a tiny formatting fix,
A tidy little hop — quick change, clever mix. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title claims to replace esbuild with rolldown, but the changes show replacing tsx with unrun and updating pnpm workspace overrides—no rolldown migration is evident. Revise the title to accurately reflect the main changes, such as 'Replace tsx with unrun and update pnpm workspace overrides' or clarify the rolldown changes if present.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch exp-no-esbuild

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 90fcd3e and bb5f3c2.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Socket Security: Pull Request Alerts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls-official
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 8ae01bc on exp-no-esbuild
into eb875ef on master.

@coveralls-official
Copy link

coveralls-official bot commented Nov 10, 2025

Coverage Status

coverage: 100.0%. remained the same
when pulling bb5f3c2 on exp-no-esbuild
into ddd0173 on master.

@RobinTail RobinTail changed the title Exp: replacing esbuild with rolldown Replacing esbuild with rolldown Nov 22, 2025
RobinTail added a commit that referenced this pull request Nov 22, 2025
Does not work well for `unrun`, causes unclear crashes and resolution
uncertainty over `ramda` in #3054

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
* Updated module import paths and TypeScript compilation configuration
for improved build compatibility.
  * Standardized JSON module import syntax across the codebase.
* Enhanced internal API infrastructure with extended interface support
for advanced use cases.

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
RobinTail added a commit that referenced this pull request Nov 22, 2025
Copy of #3055 , because the issue in #3054 is not caused by it
Since `tsdown` is going to keep it anyway, it can replace `tsx`
Should go along with #3051
All that will help to get rid of `esbuild` and use faster approach based
on Rust.
@RobinTail RobinTail changed the title Replacing esbuild with rolldown Exp: Replacing esbuild with rolldown Nov 22, 2025
@RobinTail RobinTail added the external bug it's a bug, but in a dependency label Nov 22, 2025
@RobinTail
Copy link
Owner Author

RobinTail commented Nov 22, 2025

unrun after certain update is failing to import ramda and it's causing failure

Filed an issue to unrun:
Gugustinette/unrun#11

@RobinTail RobinTail changed the title Exp: Replacing esbuild with rolldown Replacing esbuild with rolldown Nov 29, 2025
@RobinTail
Copy link
Owner Author

The experiment is a success.
I'm going to wait vite to stabilize on migrating to rolldown

@RobinTail RobinTail removed the external bug it's a bug, but in a dependency label Nov 29, 2025
@RobinTail RobinTail added the patched Some dependency is patched label Nov 29, 2025
# Conflicts:
#	pnpm-lock.yaml
@RobinTail
Copy link
Owner Author

RobinTail commented Dec 4, 2025

Can now use vite v8 beta for this
https://vite.dev/blog/announcing-vite8-beta

@RobinTail
Copy link
Owner Author

RobinTail commented Dec 5, 2025

I noticed that unrun being spawned by vitest and then killed, does actually leave the process running.
Gugustinette/unrun#13
it's fixed

@RobinTail RobinTail marked this pull request as ready for review December 6, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD dependencies Pull requests that update a dependency file patched Some dependency is patched

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants