Make records from classes, remove obsolete stuff

Author: RobThree

SimpleFeedReader/FeedItem.cs

@@ -5,58 +5,52 @@ namespace SimpleFeedReader;
 /// <summary>
 /// Represents an item from a <see cref="SyndicationFeed"/>.
 /// </summary>
-public class FeedItem
+public record FeedItem
 {
     /// <summary>
     /// The Id of the <see cref="FeedItem"/>.
     /// </summary>
-    public string? Id { get; set; }
+    public string? Id { get; init; }
 
     /// <summary>
     /// The Title of the <see cref="FeedItem"/>.
     /// </summary>
-    public string? Title { get; set; }
+    public string? Title { get; init; }
 
     /// <summary>
     /// The Content of the <see cref="FeedItem"/>.
     /// </summary>
-    public string? Content { get; set; }
+    public string? Content { get; init; }
 
     /// <summary>
     /// The Summary of the <see cref="FeedItem"/>.
     /// </summary>
-    public string? Summary { get; set; }
+    public string? Summary { get; init; }
 
     /// <summary>
     /// The Uri of the <see cref="FeedItem"/>.
     /// </summary>
-    public Uri? Uri { get; set; }
+    public Uri? Uri { get; init; }
 
     /// <summary>
     /// The images of the <see cref="FeedItem"/>.
     /// </summary>
-    public IEnumerable<Uri>? Images { get; set; }
+    public IEnumerable<Uri>? Images { get; init; }
 
     /// <summary>
     /// The vategories of the <see cref="FeedItem"/>.
     /// </summary>
-    public IEnumerable<string>? Categories { get; set; }
-
-    /// <summary>
-    /// The Date of the <see cref="FeedItem"/>.
-    /// </summary>
-    [Obsolete("Split into PublishDate and LastUpdatedDate")]
-    public DateTimeOffset? Date => new[] { PublishDate, LastUpdatedDate }.Max();
+    public IEnumerable<string>? Categories { get; init; }
 
     /// <summary>
     /// The publication date of the <see cref="FeedItem"/>.
     /// </summary>
-    public DateTimeOffset? PublishDate { get; set; }
+    public DateTimeOffset? PublishDate { get; init; }
 
     /// <summary>
     /// The date when the feeditem was last updated <see cref="FeedItem"/>.
     /// </summary>
-    public DateTimeOffset? LastUpdatedDate { get; set; }
+    public DateTimeOffset? LastUpdatedDate { get; init; }
 
     /// <summary>
     /// Initializes a new <see cref="FeedItem"/>.
@@ -67,24 +61,6 @@ public FeedItem()
         Categories = [];
     }
 
-    /// <summary>
-    /// Initializes a new <see cref="FeedItem"/> by copying the passed item's properties into the new instance.
-    /// </summary>
-    /// <param name="item">The <see cref="FeedItem"/> to copy.</param>
-    /// <remarks>This is a copy-constructor.</remarks>
-    public FeedItem(FeedItem item)
-        : this()
-    {
-        Title = item.Title;
-        Content = item.Content;
-        Summary = item.Summary;
-        Uri = item.Uri;
-        PublishDate = item.PublishDate;
-        LastUpdatedDate = item.LastUpdatedDate;
-        Images = item.Images;
-        Categories = item.Categories;
-    }
-
     /// <summary>
     /// Returns content, if any, otherwise returns the summary as content.
     /// </summary>

SimpleFeedReader/FeedReader.cs

@@ -94,7 +94,8 @@ public IEnumerable<FeedItem> RetrieveFeeds(IEnumerable<string> uris, IFeedItemNo
     /// <returns>
     /// Returns an <see cref="IEnumerable&lt;FeedItem&gt;"/> of retrieved <see cref="FeedItem"/>s.
     /// </returns>
-    public IEnumerable<FeedItem> RetrieveFeed(string uri) => RetrieveFeed(uri, DefaultNormalizer);
+    public IEnumerable<FeedItem> RetrieveFeed(string uri)
+        => RetrieveFeed(uri, DefaultNormalizer);
 
     /// <summary>
     /// Retrieves the specified feed.

SimpleFeedReader/SimpleFeedReader.csproj

@@ -29,6 +29,10 @@
 	</ItemGroup>
 
 	<ItemGroup>
+	  <PackageReference Include="PolySharp" Version="1.15.0">
+	    <PrivateAssets>all</PrivateAssets>
+	    <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+	  </PackageReference>
 	  <PackageReference Include="System.ServiceModel.Syndication" Version="9.0.2" />
 	</ItemGroup>
 </Project>

SimpleFeedReaderTests/FeedReaderTests.cs

@@ -36,11 +36,6 @@ public void BasicRSSFeedTest()
 
         Assert.IsTrue(items[0].GetContent()?.StartsWith("Lorem ipsum dolor sit"));
         Assert.IsTrue(items[0].GetSummary()?.StartsWith("Lorem ipsum dolor sit"));
-
-#pragma warning disable 0618
-        Assert.AreEqual(DateTimeOffset.Parse("2014-04-16T13:57:35.0000000+02:00", CultureInfo.InvariantCulture, DateTimeStyles.None), items[0].Date);
-        Assert.AreEqual(DateTimeOffset.MinValue, items[1].Date);
-#pragma warning restore 0618
     }
 
     [TestMethod]
@@ -69,12 +64,6 @@ public void BasicRSSWithImageFeedTest()
 
         Assert.IsTrue(items[0].GetContent()?.StartsWith("Lorem ipsum dolor sit"));
         Assert.IsTrue(items[0].GetSummary()?.StartsWith("Lorem ipsum dolor sit"));
-
-#pragma warning disable 0618
-        Assert.AreEqual(DateTimeOffset.Parse("2014-04-16T13:57:35.0000000+02:00", CultureInfo.InvariantCulture, DateTimeStyles.None), items[0].Date);
-        Assert.AreEqual(DateTimeOffset.MinValue, items[1].Date);
-#pragma warning restore 0618
-
         Assert.AreEqual(2, items[0]?.Images?.Count());
         Assert.AreEqual("http://example.org/foo/bar/123abc.png", items[0].Images?.ElementAt(0).ToString());
         Assert.AreEqual("http://example.org/foo/bar/123abc_2.png", items[0].Images?.ElementAt(1).ToString());
@@ -168,11 +157,6 @@ public void BasicAtomFeedTest()
         Assert.AreEqual("urn:uuid:d58672c4-f62e-483e-ab00-ff0940113e29", items[1].Id);
         Assert.AreEqual(DateTimeOffset.MinValue, items[1].PublishDate);
         Assert.AreEqual(DateTimeOffset.MinValue, items[1].LastUpdatedDate);
-
-#pragma warning disable 0618
-        Assert.AreEqual(DateTimeOffset.Parse("2014-04-16T13:57:35.0000000+00:00", CultureInfo.InvariantCulture, DateTimeStyles.None), items[0].Date);
-        Assert.AreEqual(DateTimeOffset.MinValue, items[1].Date);
-#pragma warning restore 0618
     }
 
     [TestMethod]
@@ -223,7 +207,7 @@ public void BasicAtomCategoriesTest()
     }
 
     #region TestClasses
-    private class ExtendedFeedItem : FeedItem
+    private record ExtendedFeedItem : FeedItem
     {
         public string[]? Authors { get; set; }