fix possible infinite loop on high-load

RevenantX · RevenantX · commit 6de47e62ffc2 · 2020-08-02T20:53:54.000+03:00
diff --git a/LiteNetLib/NetManager.cs b/LiteNetLib/NetManager.cs
@@ -1333,16 +1333,12 @@ public void PollEvents()
         {
             if (UnsyncedEvents)
                 return;
-            while (true)
+            int eventsCount = _netEventsQueue.Count;
+            for(int i = 0; i < eventsCount; i++)
             {
                 NetEvent evt;
                 lock (_netEventsQueue)
-                {
-                    if (_netEventsQueue.Count > 0)
-                        evt = _netEventsQueue.Dequeue();
-                    else
-                        return;
-                }
+                    evt = _netEventsQueue.Dequeue();
                 ProcessEvent(evt);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -1333,16 +1333,12 @@ public void PollEvents()`
`1333`	`1333`	`{`
`1334`	`1334`	`if (UnsyncedEvents)`
`1335`	`1335`	`return;`
`1336`		`- while (true)`
	`1336`	`+ int eventsCount = _netEventsQueue.Count;`
	`1337`	`+ for(int i = 0; i < eventsCount; i++)`
`1337`	`1338`	`{`
`1338`	`1339`	`NetEvent evt;`
`1339`	`1340`	`lock (_netEventsQueue)`
`1340`		`- {`
`1341`		`- if (_netEventsQueue.Count > 0)`
`1342`		`- evt = _netEventsQueue.Dequeue();`
`1343`		`- else`
`1344`		`- return;`
`1345`		`- }`
	`1341`	`+ evt = _netEventsQueue.Dequeue();`
`1346`	`1342`	`ProcessEvent(evt);`
`1347`	`1343`	`}`
`1348`	`1344`	`}`