Skip to content

Catch more type of error from Firebase #932

@fgarzonhz

Description

@fgarzonhz

What version of PushSharp are you using?

4.0

Describe your issue:

Firebase return an error but using the code from the client only catch the words "unknow error"

in c#
P.pushGoogle2.OnNotificationFailed += (notification, aggregateEx) =>
{ aggregateEx.Handle(ex =>
{
console.write(ex.Message + " : " + ex.StackTrace.ToString()); //here only print "error"

What are the steps required to reproduce this issue?

Firebase return the error: {"multicast_id":99999999,"success":0,"failure":1,"canonical_ids":0,"results":[{"error":"InvalidApnsCredential"}]}

Please provide any Exception Stack Traces

I saw the pushsharp code and we need to add a new enum to catch InvalidApnsCredential (may suggestio in related in line 203 of file GCmServiceConnection.cs [ static GcmResponseStatus GetGcmResponseStatus (string str) ])

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions