small enhancements

Author: DarthB

src/context/call_reply.rs

@@ -699,20 +699,20 @@ pub enum CallReply<'root> {
 }
 
 impl<'root> CallReply<'root> {
-    /// Return the raw pointer to the underlying [RedisModuleCallReply].
-    pub fn get_raw(&self) -> *mut RedisModuleCallReply {
+    /// Return the raw pointer to the underlying [RedisModuleCallReply], or `None` if this is the `Unknown` variant.
+    pub fn get_raw(&self) -> Option<*mut RedisModuleCallReply> {
         match self {
-            CallReply::Unknown => std::ptr::null_mut(),
-            CallReply::I64(inner) => inner.get_raw(),
-            CallReply::String(inner) => inner.get_raw(),
-            CallReply::Array(inner) => inner.get_raw(),
-            CallReply::Null(inner) => inner.get_raw(),
-            CallReply::Map(inner) => inner.get_raw(),
-            CallReply::Set(inner) => inner.get_raw(),
-            CallReply::Bool(inner) => inner.get_raw(),
-            CallReply::Double(inner) => inner.get_raw(),
-            CallReply::BigNumber(inner) => inner.get_raw(),
-            CallReply::VerbatimString(inner) => inner.get_raw(),
+            CallReply::Unknown => None,
+            CallReply::I64(inner) => Some(inner.get_raw()),
+            CallReply::String(inner) => Some(inner.get_raw()),
+            CallReply::Array(inner) => Some(inner.get_raw()),
+            CallReply::Null(inner) => Some(inner.get_raw()),
+            CallReply::Map(inner) => Some(inner.get_raw()),
+            CallReply::Set(inner) => Some(inner.get_raw()),
+            CallReply::Bool(inner) => Some(inner.get_raw()),
+            CallReply::Double(inner) => Some(inner.get_raw()),
+            CallReply::BigNumber(inner) => Some(inner.get_raw()),
+            CallReply::VerbatimString(inner) => Some(inner.get_raw()),
         }
     }
 }

src/context/key_cursor.rs

@@ -70,7 +70,7 @@ impl ScanKeyCursor {
     ///
     /// ## Example
     ///
-    /// ```
+    /// ```ignore
     /// while cursor.scan(|_key, field, value| {
     ///    // do something with field and value
     /// }) {

src/redismodule.rs

@@ -161,7 +161,7 @@ impl RedisString {
         Self { ctx, inner }
     }
 
-    /// Create a RedisString from a raw C string and length. The String will be copied.
+    /// Create a RedisString from a raw C string and length. The provided C String will be copied.
     ///
     /// # Safety
     /// The caller must ensure that the provided pointer is valid and points to a memory region

tests/integration.rs

@@ -210,7 +210,10 @@ fn test_scan_key() -> Result<()> {
         .query::<()>(&mut con)
         .with_context(|| "failed to hset")?;
 
-    let res: Vec<String> = redis::cmd("scan_key").arg(&["user:123"]).query(&mut con)?;
+    let res: Vec<String> = redis::cmd("scan_key")
+        .arg(&["user:123"])
+        .query(&mut con)
+        .with_context(|| "failed scan_key")?;
     assert_eq!(&res, &["name", "Alice", "age", "29", "location", "Austin"]);
     Ok(())
 }
@@ -227,7 +230,8 @@ fn test_scan_key_for_each() -> Result<()> {
 
     let res: Vec<String> = redis::cmd("scan_key_for_each")
         .arg(&["user:123"])
-        .query(&mut con)?;
+        .query(&mut con)
+        .with_context(|| "failed scan_key_for_each")?;
     assert_eq!(&res, &["name", "Alice", "age", "29", "location", "Austin"]);
     Ok(())
 }