Group Tests When Running In Github CI (#236)

* initial commit

* Add message and depth parameters to all Query assertions (#237)

* add depth and message for Query, and some related fixes

* remove unused import

* CI update (#238)

* split nightly from generic CI

* version bump actions

* update poetry lock

* remove usage of pkg_resources

* bump poetry version

* update toml and poetry lock again

* fix whitespace

* Rename nightly-build job to build in biweekly.yml

* support version on python 3.7

* run CI on older and newer python version

* add old versions back and lock poetry

* fix run

* another attempt

* another attempt

* another attempt

* another attempt

* another attempt

* another attempt

* another attempt

* fix poetry lock

* CI improvement

* improve comment and concurrency group

* add failure notification

* Improve waitCluster (#239)

* refactor to use cluster slots to ensure agreement

* expose to Env

* wait for both OK and same topo

* minor improvements

* print rltest args

* code review comments

* code review comments

* fixes

* small fix

* remove redundant function call

* Apply suggestions from code review

Co-authored-by: GuyAv46 <47632673+GuyAv46@users.noreply.github.com>

---------

Co-authored-by: GuyAv46 <47632673+GuyAv46@users.noreply.github.com>

Author: kei-nan

RLTest/__main__.py

@@ -15,7 +15,7 @@
 from multiprocessing import Process, Queue, set_start_method
 
 from RLTest.env import Env, TestAssertionFailure, Defaults
-from RLTest.utils import Colors, fix_modules, fix_modulesArgs
+from RLTest.utils import Colors, fix_modules, fix_modulesArgs, is_github_actions
 from RLTest.loader import TestLoader
 from RLTest.Enterprise import binaryrepo
 from RLTest import debuggers
@@ -553,6 +553,9 @@ def __init__(self):
         self.testsFailed = {}
         self.currEnv = None
         self.loader = TestLoader()
+
+        # For GitHub Actions grouping - track if we have an open group
+        self.github_actions_group_open = False if is_github_actions() else None
         if self.args.test is not None:
             self.loader.load_spec(self.args.test)
         if self.args.tests_file is not None:
@@ -769,6 +772,18 @@ def _runTest(self, test, numberOfAssertionFailed=0, prefix='', before=lambda x=N
             numFailed += 1 # exception should be counted as failure
         return numFailed
 
+    def _openGitHubActionsTestsGroup(self):
+        """Open a GitHub Actions group wrapping all tests"""
+        if self.github_actions_group_open is False:
+            print('::group::📋 Test Execution')
+            self.github_actions_group_open = True
+
+    def _closeGitHubActionsTestsGroup(self):
+        """Close the GitHub Actions tests group if one is open"""
+        if self.github_actions_group_open is True:
+            print('::endgroup::')
+            self.github_actions_group_open = False
+
     def printSkip(self, name):
         print('%s:\r\n\t%s' % (Colors.Cyan(name), Colors.Green('[SKIP]')))
 
@@ -799,6 +814,7 @@ def killEnvWithSegFault(self):
         else:
             self.stopEnvWithSegFault()
 
+    # return number of tests done, and if all passed
     def run_single_test(self, test, on_timeout_func):
         done = 0
         with TestTimeLimit(self.args.test_timeout, on_timeout_func) as timeout_handler:
@@ -955,6 +971,8 @@ def on_timeout():
 
         results = Queue()
         summary = Queue()
+        # Open group for all tests at the start (parallel execution)
+        self._openGitHubActionsTestsGroup()
         if self.parallelism == 1:
             run_jobs_main_thread(jobs)
         else :
@@ -996,6 +1014,10 @@ def on_timeout():
 
         endTime = time.time()
 
+        # Close group after all tests complete (parallel execution)
+        self._closeGitHubActionsTestsGroup()
+
+        # Summary goes outside the group
         print(Colors.Bold('\nTest Took: %d sec' % (endTime - startTime)))
         print(Colors.Bold('Total Tests Run: %d, Total Tests Failed: %d, Total Tests Passed: %d' % (done, self.getFailedTestsCount(), done - self.getFailedTestsCount())))
         if self.testsFailed:

RLTest/utils.py

@@ -6,6 +6,12 @@
 import redis
 import itertools
 
+
+def is_github_actions():
+    """Check if running in GitHub Actions environment"""
+    return os.getenv('GITHUB_ACTIONS', '') != ''
+
+
 def wait_for_conn(conn, proc, retries=20, command='PING', shouldBe=True):
     """Wait until a given Redis connection is ready"""
     err1 = ''