[add] added BF.INSERT tests for NONSCALING and and NOCREATE

Author: filipecosta90

Gopkg.lock

@@ -156,7 +156,7 @@ func (client *Client) BfLoadChunk(key string, iter int64, data []byte) (string,
 }
 
 // This command will add one or more items to the bloom filter, by default creating it if it does not yet exist.
-func (client *Client) BfInsert(key string, cap int64, errorRatio float64, expansion int64, noCreate bool, nonScaling bool, items []string) ([]int64, error) {
+func (client *Client) BfInsert(key string, cap int64, errorRatio float64, expansion int64, noCreate bool, nonScaling bool, items []string) (res []int64, err error) {
 	conn := client.Pool.Get()
 	defer conn.Close()
 	args := redis.Args{key}
@@ -176,7 +176,21 @@ func (client *Client) BfInsert(key string, cap int64, errorRatio float64, expans
 		args = args.Add("NONSCALING")
 	}
 	args = args.Add("ITEMS").AddFlat(items)
-	return redis.Int64s(conn.Do("BF.INSERT", args...))
+	var resp []interface{}
+	var innerRes int64
+	resp, err = redis.Values(conn.Do("BF.INSERT", args...))
+	if err != nil {
+		return
+	}
+	for _, arrayPos := range resp {
+		innerRes, err = redis.Int64(arrayPos, err)
+		if err == nil {
+			res = append(res, innerRes)
+		} else {
+			break
+		}
+	}
+	return
 }
 
 // Initializes a TopK with specified parameters.

Gopkg.toml

@@ -133,6 +133,9 @@ func TestClient_BfExistsMulti(t *testing.T) {
 func TestClient_BfInsert(t *testing.T) {
 	client.FlushAll()
 	key := "test_bf_insert"
+	key_nocreate := "test_bf_insert_nocreate"
+	key_noscaling := "test_bf_insert_noscaling"
+
 	ret, err := client.BfInsert(key, 1000, 0.1, -1, false, false, []string{"a"})
 	assert.Nil(t, err)
 	assert.Equal(t, 1, len(ret))
@@ -141,6 +144,23 @@ func TestClient_BfInsert(t *testing.T) {
 	assert.Nil(t, err)
 	assert.Equal(t, 1, len(existsResult))
 	assert.Equal(t, int64(1), existsResult[0])
+
+	ret, err = client.BfInsert(key, 1000, 0.1, -1, false, false, []string{"a", "b"})
+	assert.Nil(t, err)
+	assert.Equal(t, 2, len(ret))
+
+	// Test for NOCREATE : If specified, indicates that the filter should not be created if it does not already exist
+	_, err = client.BfInsert(key_nocreate, 1000, 0.1, -1, true, false, []string{"a"})
+	assert.NotNil(t, err)
+
+	// Test NONSCALING : Prevents the filter from creating additional sub-filters if initial capacity is reached.
+	ret, err = client.BfInsert(key_noscaling, 2, 0.1, -1, false, true, []string{"a", "b"})
+	assert.Nil(t, err)
+	assert.Equal(t, 2, len(ret))
+	ret, err = client.BfInsert(key_noscaling, 2, 0.1, -1, false, true, []string{"c"})
+	assert.NotNil(t, err)
+	assert.Equal(t, 0, len(ret))
+	assert.Equal(t, err.Error(), "ERR non scaling filter is full")
 }
 
 func TestClient_TopkReserve(t *testing.T) {