Return boolean from AccountTypes#student_account?
#91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test coverage: 100.0% |
floehopper
force-pushed
the
fix-student-account-predicate-return-value
branch
from
42a77bf to
03377c2
Compare
Previously this method returned either `0` or `nil`. This works fine in Ruby, because `0` is truth-y, but it causes problems if you want to persist the value in a Postgres boolean type, because `0` is cast to `FALSE`. The new implementation always returns either `true` or `false`. This will mean we can remove this workaround [1] in experience-cs. [1]: https://github.com/RaspberryPiFoundation/experience-cs/commit/130592b833509a52aac1511bb17320a4d7eadeb4
floehopper
force-pushed
the
fix-student-account-predicate-return-value
branch
from
03377c2 to
55fea6b
Compare
sebjacobs
approved these changes
Aug 18, 2025
floehopper
added a commit
that referenced
this pull request
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this method returned either
0ornil. This works fine in Ruby, because0is truth-y, but it causes problems if you want to persist the value in a Postgres boolean type, because0is cast toFALSE. The new implementation always returns eithertrueorfalse.This will mean we can remove this workaround in
experience-cs.