Rubocop; move enable_auth_bypass into add_middleware block

Author: patch0

lib/rpi_auth/configuration.rb

@@ -20,7 +20,6 @@ class Configuration
                   :user_model
 
     def initialize
-      @brand = 'raspberrypi-org'
       @bypass_auth = false
       @response_type = :code
       @client_auth_method = :basic

lib/rpi_auth/engine.rb

@@ -13,7 +13,7 @@ class Engine < ::Rails::Engine
       OmniAuth.config.logger = Rails.logger
     end
 
-    initializer 'RpiAuth.add_middleware' do |app|
+    initializer 'RpiAuth.add_middleware' do |app| # rubocop:disable Metrics/BlockLength
       next unless RpiAuth.configuration
 
       app.middleware.use OmniAuth::Builder do
@@ -36,18 +36,14 @@ class Engine < ::Rails::Engine
             jwks_uri: RpiAuth.configuration.jwks_uri
           },
           extra_authorize_params: { brand: RpiAuth.configuration.brand },
-          allow_authorize_params: [ :login_options ],
+          allow_authorize_params: [:login_options],
           origin_param: 'returnTo'
         )
 
         OmniAuth.config.on_failure = RpiAuth::AuthController.action(:failure)
-      end
-    end
 
-    config.after_initialize do
-      next unless RpiAuth.configuration
-
-      RpiAuth.configuration.enable_auth_bypass
+        RpiAuth.configuration.enable_auth_bypass if RpiAuth.configuration.bypass_auth
+      end
     end
   end
 end

spec/dummy/config/initializers/rpi_auth.rb

@@ -8,6 +8,8 @@
   config.identity_url = 'http://localhost:3002'
   config.user_model = 'User'
 
+  config.bypass_auth = false
+
   # Profile is running in docker, so we need to set this manually.  This
   # shouldn't be needed elsewhere, unless you're getting errors saying:
   #   Invalid ID token: Issuer does not match

spec/rpi_auth/configuration_spec.rb

@@ -6,10 +6,6 @@
   let(:auth_url) { 'https://auth.com:123/' }
   let(:auth_token_url) { 'https://internal.auth.com:456' }
 
-  it 'sets a default value for brand' do
-    expect(configuration.brand).to eq 'raspberrypi-org'
-  end
-
   it 'sets a default value for client_auth_method' do
     expect(configuration.client_auth_method).to eq :basic
   end