Skip to content

Commit 788cfd3

Browse files
committed
Renamed get/set methods in TempoEvents
1 parent ec8c128 commit 788cfd3

File tree

12 files changed

+19
-19
lines changed

12 files changed

+19
-19
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ NoteBlockLib.writeSong(newSong, new File("output.nbs"));
113113
```java
114114
Song mySong = new GenericSong();
115115
mySong.setTitle("My song");
116-
mySong.getTempoEvents().setTempo(0, 10F); // set the tempo to 10 ticks per second
116+
mySong.getTempoEvents().set(0, 10F); // set the tempo to 10 ticks per second
117117
mySong.getNotes().add(0, new Note().setInstrument(MinecraftInstrument.HARP).setNbsKey((byte) 46));
118118
mySong.getNotes().add(5, new Note().setInstrument(MinecraftInstrument.BASS).setNbsKey((byte) 60));
119119
mySong.getNotes().add(8, new Note().setInstrument(MinecraftInstrument.BIT).setNbsKey((byte) 84));

src/main/java/net/raphimc/noteblocklib/format/futureclient/FutureClientIo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public static FutureClientSong readSong(final InputStream is, final String fileN
6666
}
6767

6868
{ // Fill generalized song structure with data
69-
song.getTempoEvents().setTempo(0, 20);
69+
song.getTempoEvents().set(0, 20);
7070
for (Map.Entry<Integer, List<FutureClientNote>> entry : notes.entrySet()) {
7171
for (FutureClientNote futureClientNote : entry.getValue()) {
7272
final Note note = new Note();

src/main/java/net/raphimc/noteblocklib/format/mcsp/McSpIo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public static McSpSong readSong(final InputStream is, final String fileName) {
6262
}
6363

6464
{ // Fill generalized song structure with data
65-
song.getTempoEvents().setTempo(0, 10);
65+
song.getTempoEvents().set(0, 10);
6666
for (Map.Entry<Integer, McSpNote[]> entry : notes.entrySet()) {
6767
for (McSpNote mcSpNote : entry.getValue()) {
6868
if (mcSpNote == null) continue;

src/main/java/net/raphimc/noteblocklib/format/mcsp2/McSp2Io.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public static McSp2Song readSong(final InputStream is, final String fileName) {
8181
}
8282

8383
{ // Fill generalized song structure with data
84-
song.getTempoEvents().setTempo(0, song.getTempo());
84+
song.getTempoEvents().set(0, song.getTempo());
8585
for (McSp2Layer layer : song.getLayers().values()) {
8686
for (Map.Entry<Integer, McSp2Note> noteEntry : layer.getNotes().entrySet()) {
8787
final McSp2Note mcSp2Note = noteEntry.getValue();

src/main/java/net/raphimc/noteblocklib/format/midi/MidiIo.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public static MidiSong readSong(final InputStream is, final String fileName) thr
4848
throw new IllegalArgumentException("MIDI sequence has too many ticks");
4949
}
5050

51-
song.getTempoEvents().setTempo(0, (float) (1_000_000D / ((double) MidiDefinitions.DEFAULT_TEMPO_MPQ / sequence.getResolution())));
51+
song.getTempoEvents().set(0, (float) (1_000_000D / ((double) MidiDefinitions.DEFAULT_TEMPO_MPQ / sequence.getResolution())));
5252
final byte[] channelInstruments = new byte[MidiDefinitions.CHANNEL_COUNT];
5353
final byte[] channelVolumes = new byte[MidiDefinitions.CHANNEL_COUNT];
5454
final byte[] channelPans = new byte[MidiDefinitions.CHANNEL_COUNT];
@@ -123,7 +123,7 @@ public static MidiSong readSong(final InputStream is, final String fileName) thr
123123
if (metaMessage.getType() == META_SET_TEMPO && metaMessage.getData().length == 3) {
124124
final int newMpq = ((metaMessage.getData()[0] & 0xFF) << 16) | ((metaMessage.getData()[1] & 0xFF) << 8) | (metaMessage.getData()[2] & 0xFF);
125125
final double microsPerTick = (double) newMpq / sequence.getResolution();
126-
song.getTempoEvents().setTempo((int) event.getTick(), (float) (1_000_000D / microsPerTick));
126+
song.getTempoEvents().set((int) event.getTick(), (float) (1_000_000D / microsPerTick));
127127
} else if (metaMessage.getType() == META_COPYRIGHT_NOTICE) {
128128
song.setOriginalAuthor(new String(metaMessage.getData(), StandardCharsets.US_ASCII));
129129
} else if (metaMessage.getType() == META_TRACK_NAME) {

src/main/java/net/raphimc/noteblocklib/format/nbs/NbsConverter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public static NbsSong createSong(final Song song) {
4040
final NbsSong newSong = new NbsSong();
4141
newSong.copyGeneralData(song);
4242
newSong.setLength((short) song.getNotes().getLengthInTicks());
43-
newSong.setTempo((short) Math.round(song.getTempoEvents().getTempo(0) * 100F));
43+
newSong.setTempo((short) Math.round(song.getTempoEvents().get(0) * 100F));
4444

4545
for (int tick : song.getNotes().getTicks()) {
4646
final List<Note> notes = song.getNotes().get(tick);
@@ -80,7 +80,7 @@ public static NbsSong createSong(final Song song) {
8080
newSong.getLayers().put(newSong.getLayers().size(), tempoChangerLayer);
8181

8282
for (int tempoEventTick : song.getTempoEvents().getTicks()) {
83-
final float tps = song.getTempoEvents().getTempo(tempoEventTick);
83+
final float tps = song.getTempoEvents().get(tempoEventTick);
8484
final NbsNote tempoChangerNote = new NbsNote();
8585
tempoChangerNote.setInstrument(instrumentId);
8686
tempoChangerNote.setKey((byte) NbsDefinitions.F_SHARP_4_NBS_KEY);

src/main/java/net/raphimc/noteblocklib/format/nbs/NbsIo.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ public static NbsSong readSong(final InputStream is, final String fileName) thro
140140
customInstrumentMap.put(customInstrument, customInstrument.copy().setPitch((byte) NbsDefinitions.F_SHARP_4_NBS_KEY));
141141
}
142142

143-
song.getTempoEvents().setTempo(0, song.getTempo() / 100F);
143+
song.getTempoEvents().set(0, song.getTempo() / 100F);
144144
for (NbsLayer layer : layers.values()) {
145145
for (Map.Entry<Integer, NbsNote> noteEntry : layer.getNotes().entrySet()) {
146146
final NbsNote nbsNote = noteEntry.getValue();
@@ -159,7 +159,7 @@ public static NbsSong readSong(final InputStream is, final String fileName) thro
159159
} else {
160160
final NbsCustomInstrument nbsCustomInstrument = customInstruments.get(nbsNote.getInstrument() - song.getVanillaInstrumentCount());
161161
if (song.getVersion() >= 4 && NbsDefinitions.TEMPO_CHANGER_CUSTOM_INSTRUMENT_NAME.equals(nbsCustomInstrument.getName())) {
162-
song.getTempoEvents().setTempo(noteEntry.getKey(), Math.abs(nbsNote.getPitch() / 15F));
162+
song.getTempoEvents().set(noteEntry.getKey(), Math.abs(nbsNote.getPitch() / 15F));
163163
continue;
164164
}
165165

src/main/java/net/raphimc/noteblocklib/format/txt/TxtIo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public static TxtSong readSong(final InputStream is, final String fileName) thro
6363
}
6464

6565
{ // Fill generalized song structure with data
66-
song.getTempoEvents().setTempo(0, 20);
66+
song.getTempoEvents().set(0, 20);
6767
for (Map.Entry<Integer, List<TxtNote>> entry : notes.entrySet()) {
6868
for (TxtNote txtNote : entry.getValue()) {
6969
final Note note = new Note();

src/main/java/net/raphimc/noteblocklib/model/Song.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public int tickToMilliseconds(final int tick) {
5959
int lastTick = 0;
6060
float totalMilliseconds = 0;
6161
for (int tempoTick : tempoEventTicks) {
62-
final float tps = this.tempoEvents.getTempo(lastTick);
62+
final float tps = this.tempoEvents.get(lastTick);
6363
final int ticksInSegment = tempoTick - lastTick;
6464
final float segmentMilliseconds = (ticksInSegment / tps) * 1000F;
6565
totalMilliseconds += segmentMilliseconds;
@@ -76,7 +76,7 @@ public int millisecondsToTick(final int milliseconds) {
7676
int lastTick = 0;
7777
float totalMilliseconds = 0;
7878
for (int tempoTick : tempoEventTicks) {
79-
final float tps = this.tempoEvents.getTempo(lastTick);
79+
final float tps = this.tempoEvents.get(lastTick);
8080
final int ticksInSegment = tempoTick - lastTick;
8181
final float segmentMilliseconds = (ticksInSegment / tps) * 1000F;
8282

src/main/java/net/raphimc/noteblocklib/model/TempoEvents.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,15 @@ public TempoEvents() {
3131
this.tempoEvents.put(0, DEFAULT_TEMPO);
3232
}
3333

34-
public float getTempo(final int tick) {
34+
public float get(final int tick) {
3535
return this.tempoEvents.getOrDefault(tick, 0F);
3636
}
3737

3838
public float getEffectiveTempo(final int tick) {
3939
return this.tempoEvents.floorEntry(tick).getValue();
4040
}
4141

42-
public void setTempo(final int tick, final float tempo) {
42+
public void set(final int tick, final float tempo) {
4343
this.tempoEvents.put(tick, tempo);
4444
}
4545

0 commit comments

Comments
 (0)