Ability to choose any weekday as week start #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just out of curiousity: What is an actual use case for this feature? |
Author
|
The Brazilian power schedule is reviewed weekly and the week starts on Saturday (see https://www.ons.org.br/Paginas/resultados-da-operacao/historico-da-operacao/cmo.aspx). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the commits in this pull request, the user can choose any day as the first day of the week, not only Sunday or Monday. In order to do that, the user should choose a number from 0 to 6, where 0 is Sunday and 6 is Saturday. The old syntax ("M", "S") is still accepted, so this won't break anything.
Additionally, this pull request simplifies the code as it avoids an if-else with very similar content in both conditions.