-
Notifications
You must be signed in to change notification settings - Fork 5
fix: cleaner dispatching onto StaticArrays #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Fe-r-oz
wants to merge
45
commits into
QuantumSavory:main
Choose a base branch
from
Fe-r-oz:fa/i39
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 8 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
964cb43
fix #39 Cleaner dispatching onto StaticArrays
Fe-r-oz 5b42460
some tests are broken
Fe-r-oz ca20715
use cleaner dispatching onto static arrays for gaussian unitaries
Fe-r-oz 1172889
cleaner dispatching for gaussian channels
Fe-r-oz cd8c8e2
Merge branch 'main' into fa/i39
Fe-r-oz 6721955
fix merge conflict typo caused by resolving merge conflict
Fe-r-oz dea74cd
fix errors after merge conflict
Fe-r-oz f85baa3
fixup to resolve merge conflicts errors
Fe-r-oz a7ba822
add codereview suggestions: use _infer_types via use traits instead o…
Fe-r-oz 9db705d
add wonderful codereview suggestions: minor fixes/generalizations to …
Fe-r-oz df7612e
add wonderful codereview suggestions: polish
Fe-r-oz 783ec5e
add wonderful codereview suggestions: polish
Fe-r-oz f33ef14
add more tests for SArray as well
Fe-r-oz c6f2f83
add missing comments that got removed
Fe-r-oz ec9cd51
Update ext/StaticArraysExt/utils.jl
Fe-r-oz 589be9c
add wonderful codereview suggestions: improvements to type-based disp…
Fe-r-oz 07e20fc
Merge branch 'apkille:main' into fa/i39
Fe-r-oz 67f594b
add test_broken for some errors and comment out tests for phaseshift …
Fe-r-oz f8ec8bc
add test broken error that seems to be due to equality checks for Num…
Fe-r-oz 2594d97
Update src/channels.jl
Fe-r-oz fd7050e
use dtype and ttype :)
Fe-r-oz ea6dc66
add wonderful codereview suggestions: improvements and polish
Fe-r-oz 68e5665
polish
Fe-r-oz 4fee0c8
polish
Fe-r-oz 920f216
polish
Fe-r-oz e10368b
polish tests
Fe-r-oz b4dc7c8
undo tests that used previous notation of using static arrays
Fe-r-oz 9c27458
improvements
Fe-r-oz 1ced61e
cleanup
Fe-r-oz 8526479
improvements
Fe-r-oz 631a001
improvements
Fe-r-oz 8f660b6
improvements
Fe-r-oz b5e53c5
fixup
Fe-r-oz 7cb4314
simplify the type-based dispatch
Fe-r-oz d480e0b
enhance tests in test_randoms.jl
Fe-r-oz be07b78
enhance tests in test_random.jl
Fe-r-oz 0c4799f
rm commit history that accidently got added as file
Fe-r-oz 6be59ce
add more tests for test_random.jl
Fe-r-oz d31e463
follow the test convention setup by Andrew in test_unitaries.jl
Fe-r-oz c082dfb
Merge branch 'apkille:main' into fa/i39
Fe-r-oz 8c8044f
Merge branch 'main' into fa/i39
Fe-r-oz 38d516d
undo the changes here to work on new changes
Fe-r-oz cb93ef2
Merge branch 'apkille:main' into fa/i39
Fe-r-oz 107039b
🛠️ cleaner dispatching of all gaussian states excluding EPR
Fe-r-oz b4e49e1
🧐add cleaner dispatching for EPR state
Fe-r-oz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.