better method for copying children

Author: krittick

discord/ext/pages/pagination.py

@@ -21,7 +21,6 @@
 FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 DEALINGS IN THE SOFTWARE.
 """
-import copy
 from typing import Dict, List, Optional, Union
 
 import discord
@@ -274,7 +273,6 @@ def __init__(
         self.default_button_row = default_button_row
         self.loop_pages = loop_pages
         self.custom_view = custom_view
-        self.custom_view_items = []
         self.message: Union[discord.Message, discord.WebhookMessage, None] = None
 
         if self.custom_buttons and not self.use_default_buttons:
@@ -395,6 +393,7 @@ async def disable(
         page: Optional[Union[:class:`str`, Union[List[:class:`discord.Embed`], :class:`discord.Embed`]]]
             The page content to show after disabling the paginator.
         """
+        page = self.get_page_content(page)
         for item in self.children:
             if item not in self.custom_view_items or include_custom:
                 item.disabled = True
@@ -421,9 +420,10 @@ async def cancel(
         page: Optional[Union[:class:`str`, Union[List[:class:`discord.Embed`], :class:`discord.Embed`]]]
             The page content to show after canceling the paginator.
         """
-        items = copy.copy(self.children)
+        items = self.children.copy()
+        page = self.get_page_content(page)
         for item in items:
-            if item not in self.custom_view_items or include_custom:
+            if item not in self.custom_view.children or include_custom:
                 self.remove_item(item)
         if page:
             await self.message.edit(
@@ -613,9 +613,7 @@ def update_buttons(self) -> Dict:
         # The bot developer should handle row assignments for their view before passing it to Paginator
         if self.custom_view:
             for item in self.custom_view.children:
-                self.custom_view_items.append(item)
                 self.add_item(item)
-
         return self.buttons
 
     @staticmethod

examples/views/paginator.py

@@ -182,6 +182,26 @@ async def pagetest_custom_view(self, ctx: discord.ApplicationContext):
         paginator = pages.Paginator(pages=self.get_pages(), custom_view=view)
         await paginator.respond(ctx.interaction, ephemeral=False)
 
+    @pagetest.command(name="disable")
+    async def pagetest_disable(self, ctx: discord.ApplicationContext):
+        """Demonstrates disabling the paginator buttons and showing a custom page when disabled."""
+        paginator = pages.Paginator(pages=self.get_pages())
+        await paginator.respond(ctx.interaction, ephemeral=False)
+        await ctx.respond("Disabling paginator in 5 seconds...")
+        await asyncio.sleep(5)
+        disable_page = discord.Embed(title="Paginator Disabled!", description="This page is only shown when the paginator is disabled.")
+        await paginator.disable(page=disable_page)
+
+    @pagetest.command(name="cancel")
+    async def pagetest_cancel(self, ctx: discord.ApplicationContext):
+        """Demonstrates canceling (stopping) the paginator and showing a custom page when cancelled."""
+        paginator = pages.Paginator(pages=self.get_pages())
+        await paginator.respond(ctx.interaction, ephemeral=False)
+        await ctx.respond("Canceling paginator in 5 seconds...")
+        await asyncio.sleep(5)
+        cancel_page = discord.Embed(title="Paginator Cancelled!", description="This page is only shown when the paginator is cancelled.")
+        await paginator.cancel(page=cancel_page)
+
     @pagetest.command(name="groups")
     async def pagetest_groups(self, ctx: discord.ApplicationContext):
         """Demonstrates using page groups to switch between different sets of pages."""