Fixed issues from Defelo

Author: NekoFanatic

administration/roles/cog.py

@@ -1,14 +1,13 @@
 from typing import Optional, Union, Dict, List
 
 import discord.ext.commands
-from discord import Role, Embed, Member, Status, Guild, NotFound, User, Forbidden
+from discord import Role, Embed, Member, Status, Guild, NotFound, User, Forbidden, Permissions
 from discord.ext import commands
 from discord.ext.commands import CommandError, Context, guild_only, UserInputError, Group
 
 from PyDrocsid.cog import Cog
 from PyDrocsid.command import reply, docs, optional_permissions
 from PyDrocsid.config import Config
-from ...contributor import Contributor
 from PyDrocsid.converter import UserMemberConverter
 from PyDrocsid.database import db, select, filter_by
 from PyDrocsid.embeds import send_long_embed
@@ -20,6 +19,7 @@
 from .colors import Colors
 from .models import RoleAuth, PermaRole
 from .permissions import RolesPermission
+from ...contributor import Contributor
 from ...pubsub import send_to_changelog, send_alert
 
 tg = t.g
@@ -247,54 +247,13 @@ async def roles_add(self, ctx: Context, member: Member, *, role: Role):
     @RolesPermission.roles_clone.check
     @docs(t.commands.roles_clone)
     async def roles_clone(self, ctx: Context, role: Role):
-        if not await is_authorized(ctx.author, role, perma=False):
-            raise CommandError(t.role_not_authorized)
-
-        permission_list = [
-            "add_reactions",
-            "administrator",
-            "attach_files",
-            "ban_members",
-            "change_nickname",
-            "connect",
-            "create_instant_invite",
-            "deafen_members",
-            "embed_links",
-            "external_emojis",
-            "kick_members",
-            "manage_channels",
-            "manage_emojis",
-            "manage_guild",
-            "manage_messages",
-            "manage_nicknames",
-            "manage_permissions",
-            "manage_roles",
-            "manage_webhooks",
-            "mention_everyone",
-            "move_members",
-            "mute_members",
-            "priority_speaker",
-            "read_message_history",
-            "read_messages",
-            "request_to_speak",
-            "send_messages",
-            "send_tts_messages",
-            "speak",
-            "stream",
-            "use_external_emojis",
-            "use_slash_commands",
-            "use_voice_activation",
-            "value",
-            "view_audit_log",
-            "view_channel",
-            "view_guild_insights",
-        ]
 
         missing_perms = []
+
         params = discord.Permissions()
-        bot_member_object = ctx.guild.get_member(self.bot.user.id)
+        bot_member_object = ctx.guild.me
 
-        for permission in permission_list:
+        for permission, _ in Permissions.all():
             if (
                     getattr(bot_member_object.guild_permissions,
                             permission
@@ -310,9 +269,7 @@ async def roles_clone(self, ctx: Context, role: Role):
         )
         await ctx.message.add_reaction(name_to_emoji["white_check_mark"])
         if missing_perms:
-            descrip = ""
-            for mis in missing_perms:
-                descrip += f"`{mis}`\n"
+            descrip = "`" + "`\n`".join(missing_perms) + "`"
             em = Embed(title=t.failed_to_clone_role_permissions, description=descrip, color=Colors.MissingPermissions)
             await send_long_embed(ctx, em, paginate=True)