pythongh-135379: fix MSVC warning: conversion from 'stwodigits' to 'digit' (pythonGH-135714)

chris-eibl · Pranjal095 · commit 152ca42141b4 · 2025-07-12T20:33:17.000+05:30
fix warning C4244: 'initializing': conversion from

'stwodigits' to 'digit', possible loss of data
diff --git a/Objects/longobject.c b/Objects/longobject.c
@@ -337,7 +337,7 @@ medium_from_stwodigits(stwodigits x)
         }
         _PyObject_Init((PyObject*)v, &PyLong_Type);
     }
-    digit abs_x = x < 0 ? -x : x;
+    digit abs_x = x < 0 ? (digit)(-x) : (digit)x;
     _PyLong_SetSignAndDigitCount(v, x<0?-1:1, 1);
     v->long_value.ob_digit[0] = abs_x;
     return PyStackRef_FromPyObjectStealMortal((PyObject *)v);

Original file line number	Diff line number	Diff line change
`@@ -337,7 +337,7 @@ medium_from_stwodigits(stwodigits x)`
`337`	`337`	`}`
`338`	`338`	`_PyObject_Init((PyObject*)v, &PyLong_Type);`
`339`	`339`	`}`
`340`		`- digit abs_x = x < 0 ? -x : x;`
	`340`	`+ digit abs_x = x < 0 ? (digit)(-x) : (digit)x;`
`341`	`341`	`_PyLong_SetSignAndDigitCount(v, x<0?-1:1, 1);`
`342`	`342`	`v->long_value.ob_digit[0] = abs_x;`
`343`	`343`	`return PyStackRef_FromPyObjectStealMortal((PyObject *)v);`