Added new bugprone-* and readability-* clang-tidy checks (#6363)

* Added readability-make-member-function-const fixes

* Implemented flagged bugprone-unhandled-self-assignment fixes

* Apply clang-tidy fixes for bugprone and readability checks

- Add self-assignment checks to 13 operator= methods (bugprone-unhandled-self-assignment)
- Add const qualifiers to 12 getter methods (readability-make-member-function-const)
- Remove unused RAII temporary in JointIterativeClosestPoint constructor (bugprone-unused-raii)

* Fixed clang-tidy escapes

* Fixed yet more clang-tidy escapes

* Reverted inadvertent reformatting

* Harmonized clang-tidy changes between header and source

* Standardized on most common return *this for self-assignment

* Reverted *this to (*this) in places that needed parentheses

Author: gnawme

.clang-tidy

@@ -3,6 +3,9 @@ Checks: >
     -*,
     bugprone-copy-constructor-init,
     bugprone-macro-parentheses,
+    bugprone-unhandled-self-assignment,
+    bugprone-unused-raii,
+    bugprone-use-after-move,
     cppcoreguidelines-pro-type-cstyle-cast,
     cppcoreguidelines-pro-type-static-cast-downcast,
     google-readability-casting,
@@ -37,6 +40,7 @@ Checks: >
     readability-container-size-empty,
     readability-delete-null-pointer,
     readability-duplicate-include,
+    readability-make-member-function-const,
     readability-redundant-declaration,
     readability-redundant-smartptr-get,
     readability-redundant-string-cstr,

apps/point_cloud_editor/include/pcl/apps/point_cloud_editor/command.h

@@ -89,6 +89,6 @@ class Command {
   operator=(const Command&)
   {
     assert(false);
-    return (*this);
+    return *this;
   }
 };

apps/point_cloud_editor/include/pcl/apps/point_cloud_editor/commandQueue.h

@@ -101,7 +101,7 @@ class CommandQueue {
   operator=(const CommandQueue&)
   {
     assert(false);
-    return (*this);
+    return *this;
   }
 
   /// @brief Enforces the depth limit of the command queue. If the depth is

apps/point_cloud_editor/include/pcl/apps/point_cloud_editor/statistics.h

@@ -70,7 +70,7 @@ class Statistics {
   operator=(const Statistics&)
   {
     assert(false);
-    return (*this);
+    return *this;
   }
 
   /// @brief Returns the statistics in string.

apps/point_cloud_editor/include/pcl/apps/point_cloud_editor/toolInterface.h

@@ -107,6 +107,6 @@ class ToolInterface {
   operator=(const ToolInterface&)
   {
     assert(false);
-    return (*this);
+    return *this;
   }
 };

apps/point_cloud_editor/src/cloud.cpp

@@ -137,7 +137,7 @@ Cloud::operator= (const Cloud &cloud)
   select_translate_x_ = cloud.select_translate_x_;
   select_translate_y_ = cloud.select_translate_y_;
   select_translate_z_ = cloud.select_translate_z_;
-  return (*this);
+  return *this;
 }
 
 Point3D&

apps/point_cloud_editor/src/selection.cpp

@@ -48,7 +48,7 @@ Selection::operator= (const Selection& selection)
 {
   cloud_ptr_ = selection.cloud_ptr_;
   selected_indices_ = selection.selected_indices_;
-  return (*this);
+  return *this;
 }
 
 void

common/include/pcl/PolygonMesh.h

@@ -79,7 +79,7 @@ namespace pcl
     operator += (const PolygonMesh& rhs)
     {
       concatenate((*this), rhs);
-      return (*this);
+      return *this;
     }
 
     /** \brief Add a polygon mesh to another mesh.

common/include/pcl/common/bivariate_polynomial.h

@@ -64,7 +64,13 @@ namespace pcl
       //-----OPERATORS-----
       /** = operator */
       BivariatePolynomialT&
-      operator= (const BivariatePolynomialT& other) { deepCopy (other); return *this;}
+      operator= (const BivariatePolynomialT& other)
+      {
+        if (this == &other)
+          return *this;
+        deepCopy (other);
+        return *this;
+      }
 
       //-----METHODS-----
       /** Initialize members to default values */

common/include/pcl/common/pca.h

@@ -113,7 +113,7 @@ namespace pcl
         coefficients_ = pca.coefficients_;
         eigenvalues_  = pca.eigenvalues_;
         mean_         = pca.mean_;
-        return (*this);
+        return *this;
       }
 
       /** \brief Provide a pointer to the input dataset