Skip to content

Commit 647f48d

Browse files
authored
Adolfo/money 1950 remove actioncable from sdk (#14937)
* Remove unused async code
1 parent 9235dbb commit 647f48d

File tree

9 files changed

+18
-253
lines changed

9 files changed

+18
-253
lines changed

packages/connect-react/examples/nextjs/package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/sdk/CHANGELOG.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,18 @@
11
<!-- markdownlint-disable MD024 -->
22
# Changelog
33

4+
## [1.1.1] - 2024-12-011
5+
6+
### Changed
7+
8+
- Remove deprecated asynchoronous response handling code.
9+
10+
## [1.1.0] - 2024-12-010
11+
12+
### Changed
13+
14+
- Naming and docs improvements
15+
416
## [1.0.12] - 2024-12-06
517

618
### Added

packages/sdk/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@pipedream/sdk",
3-
"version": "1.1.0",
3+
"version": "1.1.1",
44
"description": "Pipedream SDK",
55
"main": "dist/server/server/index.js",
66
"module": "dist/server/server/index.js",

packages/sdk/src/browser/async.ts

Lines changed: 0 additions & 24 deletions
This file was deleted.

packages/sdk/src/browser/index.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
// operations, like connecting accounts via Pipedream Connect. See the server/
55
// directory for the server client.
66

7-
import { BrowserAsyncResponseManager } from "./async.js";
87
import {
98
AccountsRequestResponse,
109
BaseClient,
@@ -133,7 +132,6 @@ export function createFrontendClient(opts: CreateBrowserClientOpts = {}) {
133132
* A client for interacting with the Pipedream Connect API from the browser.
134133
*/
135134
export class BrowserClient extends BaseClient {
136-
protected override asyncResponseManager: BrowserAsyncResponseManager;
137135
private baseURL: string;
138136
private iframeURL: string;
139137
private iframe?: HTMLIFrameElement;
@@ -155,10 +153,6 @@ export class BrowserClient extends BaseClient {
155153
this.iframeURL = `${this.baseURL}/_static/connect.html`;
156154
this.tokenCallback = opts.tokenCallback;
157155
this.externalUserId = opts.externalUserId;
158-
this.asyncResponseManager = new BrowserAsyncResponseManager({
159-
apiHost: this.apiHost,
160-
getConnectToken: () => this.token(),
161-
});
162156
}
163157

164158
private async token() {

packages/sdk/src/server/async.ts

Lines changed: 0 additions & 46 deletions
This file was deleted.

packages/sdk/src/server/index.ts

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import {
88
import {
99
Account, BaseClient, type AppInfo, type ConnectTokenResponse,
1010
} from "../shared";
11-
import { ServerAsyncResponseManager } from "./async";
1211
export * from "../shared";
1312

1413
/**
@@ -137,7 +136,6 @@ export function createBackendClient(opts: BackendClientOpts) {
137136
* A client for interacting with the Pipedream Connect API on the server-side.
138137
*/
139138
export class BackendClient extends BaseClient {
140-
protected override asyncResponseManager: ServerAsyncResponseManager;
141139
private oauthClient: ClientCredentials;
142140
private oauthToken?: AccessToken;
143141
protected projectId: string;
@@ -155,18 +153,6 @@ export class BackendClient extends BaseClient {
155153
this.projectId = opts.projectId;
156154

157155
this.oauthClient = this.newOauthClient(opts.credentials, this.baseApiUrl);
158-
this.asyncResponseManager = new ServerAsyncResponseManager({
159-
apiHost: this.apiHost,
160-
getOauthToken: async () => {
161-
await this.ensureValidOauthToken();
162-
return this.oauthToken as AccessToken;
163-
},
164-
getProjectId: () => {
165-
if (!this.projectId)
166-
throw "Attempted to connect to websocket without a valid Project id";
167-
return this.projectId;
168-
},
169-
});
170156
}
171157

172158
private ensureValidEnvironment(environment?: string) {

packages/sdk/src/shared/async.ts

Lines changed: 0 additions & 118 deletions
This file was deleted.

0 commit comments

Comments
 (0)