refactor(java:S100): code smell - method names should comply with a naming convention

ParanoidUser · ParanoidUser · commit f98bdfc0d147 · 2022-04-25T11:59:27.000-04:00
diff --git a/kata/7-kyu/odd-march-bits-8-bits-1/main/BitMarchArray.java b/kata/7-kyu/odd-march-bits-8-bits-1/main/BitMarchArray.java
@@ -1,7 +1,7 @@
 import java.util.Arrays;
 
 interface BitMarchArray {
-  static int[][] BitMarch(int n) {
+  static int[][] bitMarch(int n) {
     var march = new int[9 - n][8];
     for (var i = 0; i < march.length; i++) {
       Arrays.fill(march[i], 8 - i - n, 8 - i, 1);
diff --git a/kata/7-kyu/odd-march-bits-8-bits-1/test/BitMarchArrayTest.java b/kata/7-kyu/odd-march-bits-8-bits-1/test/BitMarchArrayTest.java
@@ -10,15 +10,15 @@ void sample() {
         {0, 0, 1, 1, 1, 1, 1, 0},
         {0, 1, 1, 1, 1, 1, 0, 0},
         {1, 1, 1, 1, 1, 0, 0, 0},
-    }, BitMarchArray.BitMarch(5));
+    }, BitMarchArray.bitMarch(5));
 
     assertArrayEquals(new int[][]{
         {0, 1, 1, 1, 1, 1, 1, 1},
         {1, 1, 1, 1, 1, 1, 1, 0},
-    }, BitMarchArray.BitMarch(7));
+    }, BitMarchArray.bitMarch(7));
 
     assertArrayEquals(new int[][]{
         {1, 1, 1, 1, 1, 1, 1, 1},
-    }, BitMarchArray.BitMarch(8));
+    }, BitMarchArray.bitMarch(8));
   }
 }
diff --git a/kata/7-kyu/reverse-the-bits-in-an-integer/main/BitsOfInteger.java b/kata/7-kyu/reverse-the-bits-in-an-integer/main/BitsOfInteger.java
@@ -1,7 +1,7 @@
 import static java.lang.Integer.*;
 
 interface BitsOfInteger {
-  static int reverse_bits(int n) {
+  static int reverseBits(int n) {
     return parseInt(new StringBuilder(toBinaryString(n)).reverse() + "", 2);
   }
 }
diff --git a/kata/7-kyu/reverse-the-bits-in-an-integer/test/SolutionTest.java b/kata/7-kyu/reverse-the-bits-in-an-integer/test/SolutionTest.java
@@ -5,11 +5,11 @@
 class SolutionTest {
   @Test
   void sample() {
-    assertEquals(267, BitsOfInteger.reverse_bits(417));
-    assertEquals(417, BitsOfInteger.reverse_bits(267));
-    assertEquals(0, BitsOfInteger.reverse_bits(0));
-    assertEquals(1087, BitsOfInteger.reverse_bits(2017));
-    assertEquals(1023, BitsOfInteger.reverse_bits(1023));
-    assertEquals(1, BitsOfInteger.reverse_bits(1024));
+    assertEquals(267, BitsOfInteger.reverseBits(417));
+    assertEquals(417, BitsOfInteger.reverseBits(267));
+    assertEquals(0, BitsOfInteger.reverseBits(0));
+    assertEquals(1087, BitsOfInteger.reverseBits(2017));
+    assertEquals(1023, BitsOfInteger.reverseBits(1023));
+    assertEquals(1, BitsOfInteger.reverseBits(1024));
   }
 }
diff --git a/kata/7-kyu/selective-fear-of-numbers/main/Arithmophobia.java b/kata/7-kyu/selective-fear-of-numbers/main/Arithmophobia.java
@@ -1,7 +1,7 @@
 import static java.util.Map.of;
 
 interface Arithmophobia {
-  static boolean AmIAfraid(String day, int num) {
+  static boolean amIAfraid(String day, int num) {
     return of("Mo", num == 12, "Tu", num > 95, "We", num == 34, "Th", num == 0, "Fr", num % 2 == 0, "Sa", num == 56)
         .getOrDefault(day.substring(0, 2), Math.abs(num) == 666);
   }
diff --git a/kata/7-kyu/selective-fear-of-numbers/test/SampleTest.java b/kata/7-kyu/selective-fear-of-numbers/test/SampleTest.java
@@ -6,20 +6,20 @@
 class SampleTest {
   @Test
   void sample() {
-    assertTrue(Arithmophobia.AmIAfraid("Monday", 12));
-    assertFalse(Arithmophobia.AmIAfraid("Monday", 13));
-    assertTrue(Arithmophobia.AmIAfraid("Tuesday", 965));
-    assertFalse(Arithmophobia.AmIAfraid("Tuesday", 2));
-    assertTrue(Arithmophobia.AmIAfraid("Wednesday", 34));
-    assertFalse(Arithmophobia.AmIAfraid("Wednesday", 32));
-    assertTrue(Arithmophobia.AmIAfraid("Thursday", 0));
-    assertFalse(Arithmophobia.AmIAfraid("Thursday", 2));
-    assertTrue(Arithmophobia.AmIAfraid("Friday", 2));
-    assertFalse(Arithmophobia.AmIAfraid("Friday", 3));
-    assertTrue(Arithmophobia.AmIAfraid("Saturday", 56));
-    assertFalse(Arithmophobia.AmIAfraid("Saturday", 57));
-    assertTrue(Arithmophobia.AmIAfraid("Sunday", -666));
-    assertTrue(Arithmophobia.AmIAfraid("Shmanday", -666));
-    assertFalse(Arithmophobia.AmIAfraid("Shmanday", -667));
+    assertTrue(Arithmophobia.amIAfraid("Monday", 12));
+    assertFalse(Arithmophobia.amIAfraid("Monday", 13));
+    assertTrue(Arithmophobia.amIAfraid("Tuesday", 965));
+    assertFalse(Arithmophobia.amIAfraid("Tuesday", 2));
+    assertTrue(Arithmophobia.amIAfraid("Wednesday", 34));
+    assertFalse(Arithmophobia.amIAfraid("Wednesday", 32));
+    assertTrue(Arithmophobia.amIAfraid("Thursday", 0));
+    assertFalse(Arithmophobia.amIAfraid("Thursday", 2));
+    assertTrue(Arithmophobia.amIAfraid("Friday", 2));
+    assertFalse(Arithmophobia.amIAfraid("Friday", 3));
+    assertTrue(Arithmophobia.amIAfraid("Saturday", 56));
+    assertFalse(Arithmophobia.amIAfraid("Saturday", 57));
+    assertTrue(Arithmophobia.amIAfraid("Sunday", -666));
+    assertTrue(Arithmophobia.amIAfraid("Shmanday", -666));
+    assertFalse(Arithmophobia.amIAfraid("Shmanday", -667));
   }
 }
diff --git a/kata/7-kyu/simple-string-characters/main/Kata.java b/kata/7-kyu/simple-string-characters/main/Kata.java
@@ -1,5 +1,5 @@
 interface Kata {
-  static int[] Solve(String word) {
+  static int[] solve(String word) {
     return new int[] {
         word.replaceAll("[^A-Z]", "").length(),
         word.replaceAll("[^a-z]", "").length(),
diff --git a/kata/7-kyu/simple-string-characters/test/SolutionTest.java b/kata/7-kyu/simple-string-characters/test/SolutionTest.java
@@ -5,11 +5,11 @@
 class SolutionTest {
   @Test
   void sample() {
-    assertArrayEquals(new int[]{1, 18, 3, 2}, Kata.Solve("Codewars@codewars123.com"));
-    assertArrayEquals(new int[]{8, 6, 3, 2}, Kata.Solve("CbgA5<1d-tOwUZTS8yQ"));
-    assertArrayEquals(new int[]{9, 9, 6, 9}, Kata.Solve("P*K4%>mQUDaG$h=cx2?.Czt7!Zn16p@5H"));
-    assertArrayEquals(new int[]{15, 8, 6, 9}, Kata.Solve("RYT'>s&gO-.CM9AKeH?,5317tWGpS<*x2ukXZD"));
-    assertArrayEquals(new int[]{10, 7, 3, 6}, Kata.Solve("$Cnl)Sr<7bBW-&qLHI!mY41ODe"));
-    assertArrayEquals(new int[]{7, 13, 4, 10}, Kata.Solve("@mw>0=QD-iAx!rp9TaG?o&M%l$34L.nbft"));
+    assertArrayEquals(new int[]{1, 18, 3, 2}, Kata.solve("Codewars@codewars123.com"));
+    assertArrayEquals(new int[]{8, 6, 3, 2}, Kata.solve("CbgA5<1d-tOwUZTS8yQ"));
+    assertArrayEquals(new int[]{9, 9, 6, 9}, Kata.solve("P*K4%>mQUDaG$h=cx2?.Czt7!Zn16p@5H"));
+    assertArrayEquals(new int[]{15, 8, 6, 9}, Kata.solve("RYT'>s&gO-.CM9AKeH?,5317tWGpS<*x2ukXZD"));
+    assertArrayEquals(new int[]{10, 7, 3, 6}, Kata.solve("$Cnl)Sr<7bBW-&qLHI!mY41ODe"));
+    assertArrayEquals(new int[]{7, 13, 4, 10}, Kata.solve("@mw>0=QD-iAx!rp9TaG?o&M%l$34L.nbft"));
   }
 }
diff --git a/kata/7-kyu/suitcase-packing/main/MrSquare.java b/kata/7-kyu/suitcase-packing/main/MrSquare.java
@@ -1,5 +1,5 @@
 interface MrSquare {
-  static boolean fit_in(int a, int b, int m, int n) {
+  static boolean fitIn(int a, int b, int m, int n) {
     return a + b <= Math.max(m, n) && Math.max(a, b) <= Math.min(m, n);
   }
 }
diff --git a/kata/7-kyu/suitcase-packing/test/TestSuitcase.java b/kata/7-kyu/suitcase-packing/test/TestSuitcase.java
@@ -6,11 +6,11 @@
 class TestSuitcase {
   @Test
   void sample() {
-    assertTrue(MrSquare.fit_in(1, 2, 3, 2));
-    assertFalse(MrSquare.fit_in(1, 2, 2, 1));
-    assertFalse(MrSquare.fit_in(3, 2, 3, 2));
-    assertFalse(MrSquare.fit_in(1, 2, 1, 2));
-    assertFalse(MrSquare.fit_in(6, 5, 8, 7));
-    assertFalse(MrSquare.fit_in(4, 1, 5, 3));
+    assertTrue(MrSquare.fitIn(1, 2, 3, 2));
+    assertFalse(MrSquare.fitIn(1, 2, 2, 1));
+    assertFalse(MrSquare.fitIn(3, 2, 3, 2));
+    assertFalse(MrSquare.fitIn(1, 2, 1, 2));
+    assertFalse(MrSquare.fitIn(6, 5, 8, 7));
+    assertFalse(MrSquare.fitIn(4, 1, 5, 3));
   }
 }
diff --git a/kata/beta/02-sum-of-arrays-elements/main/LearningJava.java b/kata/beta/02-sum-of-arrays-elements/main/LearningJava.java
@@ -1,7 +1,7 @@
 import static java.util.stream.IntStream.rangeClosed;
 
 interface LearningJava {
-  static int Sum1(int[] array) {
+  static int sum(int[] array) {
     return rangeClosed(1, array.length).map(i -> i * array[i - 1]).sum();
   }
 }
diff --git a/kata/beta/02-sum-of-arrays-elements/test/SolutionTest.java b/kata/beta/02-sum-of-arrays-elements/test/SolutionTest.java
@@ -5,8 +5,8 @@
 class SolutionTest {
   @Test
   void sample() {
-    assertEquals(30, LearningJava.Sum1(new int[]{8, 5, 4}));
-    assertEquals(22, LearningJava.Sum1(new int[]{4, 9}));
-    assertEquals(35, LearningJava.Sum1(new int[]{5, 4, 3, 2, 1}));
+    assertEquals(30, LearningJava.sum(new int[]{8, 5, 4}));
+    assertEquals(22, LearningJava.sum(new int[]{4, 9}));
+    assertEquals(35, LearningJava.sum(new int[]{5, 4, 3, 2, 1}));
   }
 }
diff --git a/kata/beta/center-of-array/main/Center.java b/kata/beta/center-of-array/main/Center.java
@@ -1,5 +1,5 @@
 interface Center {
-  static int FindCenter(int[] arr) {
+  static int findCenter(int[] arr) {
     return arr[arr.length / 2];
   }
 }
diff --git a/kata/beta/center-of-array/test/CenterTest.java b/kata/beta/center-of-array/test/CenterTest.java
@@ -5,8 +5,8 @@
 class CenterTest {
   @Test
   void sample() {
-    assertEquals(1, Center.FindCenter(new int[]{4, 1, 9}));
-    assertEquals(5, Center.FindCenter(new int[]{7, 4, 5, 8, 9}));
-    assertEquals(10, Center.FindCenter(new int[]{3, 1, 7, 10, 8, 1, 12}));
+    assertEquals(1, Center.findCenter(new int[]{4, 1, 9}));
+    assertEquals(5, Center.findCenter(new int[]{7, 4, 5, 8, 9}));
+    assertEquals(10, Center.findCenter(new int[]{3, 1, 7, 10, 8, 1, 12}));
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`import static java.lang.Integer.*;`
`2`	`2`
`3`	`3`	`interface BitsOfInteger {`
`4`		`- static int reverse_bits(int n) {`
	`4`	`+ static int reverseBits(int n) {`
`5`	`5`	`return parseInt(new StringBuilder(toBinaryString(n)).reverse() + "", 2);`
`6`	`6`	`}`
`7`	`7`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`import static java.util.Map.of;`
`2`	`2`
`3`	`3`	`interface Arithmophobia {`
`4`		`- static boolean AmIAfraid(String day, int num) {`
	`4`	`+ static boolean amIAfraid(String day, int num) {`
`5`	`5`	`return of("Mo", num == 12, "Tu", num > 95, "We", num == 34, "Th", num == 0, "Fr", num % 2 == 0, "Sa", num == 56)`
`6`	`6`	`.getOrDefault(day.substring(0, 2), Math.abs(num) == 666);`
`7`	`7`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`interface MrSquare {`
`2`		`- static boolean fit_in(int a, int b, int m, int n) {`
	`2`	`+ static boolean fitIn(int a, int b, int m, int n) {`
`3`	`3`	`return a + b <= Math.max(m, n) && Math.max(a, b) <= Math.min(m, n);`
`4`	`4`	`}`
`5`	`5`	`}`