Skip to content

Commit 7ca7a1a

Browse files
committed
Fix GitHub login
1 parent 0b4781a commit 7ca7a1a

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

.github/workflows/deploy.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,4 @@ jobs:
2727
directory: "web/.svelte-kit/cloudflare"
2828
deploymentName: Production
2929
env:
30-
VITE_GITHUB_CLIENT_ID: ${{ secrets.VITE_GITHUB_CLIENT_ID }}
31-
VITE_GITHUB_CLIENT_SECRET: ${{ secrets.VITE_GITHUB_CLIENT_SECRET }}
30+
GITHUB_CLIENT_SECRET: ${{ secrets.VITE_GITHUB_CLIENT_SECRET }}

web/.env

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
PUBLIC_GITHUB_CLIENT_ID=Iv23lio9NNdLLYjZ363a
22
PUBLIC_GITHUB_APP_NAME=diffs-dev
3+
GITHUB_CLIENT_SECRET=secret

web/src/routes/github-token/+server.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
import type { RequestHandler } from "@sveltejs/kit";
2+
import { PUBLIC_GITHUB_CLIENT_ID } from "$env/static/public";
3+
import { GITHUB_CLIENT_SECRET } from "$env/static/private";
24

35
export const POST: RequestHandler = async ({ url }) => {
46
const code = url.searchParams.get("code");
@@ -7,8 +9,8 @@ export const POST: RequestHandler = async ({ url }) => {
79
}
810
const state = url.searchParams.get("state");
911
const body = {
10-
client_id: import.meta.env.VITE_GITHUB_CLIENT_ID,
11-
client_secret: import.meta.env.VITE_GITHUB_CLIENT_SECRET,
12+
client_id: PUBLIC_GITHUB_CLIENT_ID,
13+
client_secret: GITHUB_CLIENT_SECRET,
1214
code,
1315
state,
1416
};

0 commit comments

Comments
 (0)