Remove parallel array for tracking header-change-only patches

Author: jpenilla

web/src/lib/components/diff/concise-diff-view.svelte.ts

@@ -676,6 +676,19 @@ async function makeHunk(
     return { lines };
 }
 
+export function patchHeaderDiffOnly(patch: StructuredPatch): boolean {
+    if (patch.hunks.length === 0) {
+        return false;
+    }
+    let onlyHeaderChanges = true;
+    for (let j = 0; j < patch.hunks.length; j++) {
+        if (hasNonHeaderChanges(patch.hunks[j].lines)) {
+            onlyHeaderChanges = false;
+        }
+    }
+    return onlyHeaderChanges;
+}
+
 export function hasNonHeaderChanges(contentLines: string[]) {
     for (const line of contentLines) {
         if (lineHasNonHeaderChange(line)) {

web/src/lib/diff-viewer-multi-file.svelte.ts

@@ -4,9 +4,9 @@ import {
     ConciseDiffViewCachedState,
     DEFAULT_THEME_DARK,
     DEFAULT_THEME_LIGHT,
-    hasNonHeaderChanges,
     isNoNewlineAtEofLine,
     parseSinglePatch,
+    patchHeaderDiffOnly,
 } from "$lib/components/diff/concise-diff-view.svelte";
 import type { BundledTheme } from "shiki";
 import { browser } from "$app/environment";
@@ -151,6 +151,7 @@ export type CommonFileDetails = {
 export type TextFileDetails = CommonFileDetails & {
     type: "text";
     structuredPatch: StructuredPatch;
+    patchHeaderDiffOnly: boolean;
 };
 
 export type ImageFileDetails = CommonFileDetails & {
@@ -159,12 +160,14 @@ export type ImageFileDetails = CommonFileDetails & {
 };
 
 export function makeTextDetails(fromFile: string, toFile: string, status: FileStatus, patchText: string): TextFileDetails {
+    const patch = parseSinglePatch(patchText);
     return {
         type: "text",
         fromFile,
         toFile,
         status,
-        structuredPatch: parseSinglePatch(patchText),
+        structuredPatch: patch,
+        patchHeaderDiffOnly: patchHeaderDiffOnly(patch),
     };
 }
 
@@ -283,30 +286,6 @@ export function getFileStatusProps(status: FileStatus): FileStatusProps {
     }
 }
 
-export function findHeaderChangeOnlyPatches(fileDetails: FileDetails[]) {
-    const result: boolean[] = [];
-
-    for (const details of fileDetails) {
-        if (details.type !== "text") {
-            result.push(false);
-            continue;
-        }
-        if (details.structuredPatch.hunks.length === 0) {
-            result.push(false);
-            continue;
-        }
-        let onlyHeaderChanges = true;
-        for (let j = 0; j < details.structuredPatch.hunks.length; j++) {
-            if (hasNonHeaderChanges(details.structuredPatch.hunks[j].lines)) {
-                onlyHeaderChanges = false;
-            }
-        }
-        result.push(onlyHeaderChanges);
-    }
-
-    return result;
-}
-
 export type ViewerStatistics = {
     addedLines: number;
     removedLines: number;
@@ -356,14 +335,17 @@ export class MultiFileDiffViewerState {
     readonly filteredFileDetails: FileDetails[] = $derived(
         this.fileTreeFilterDebounced.current ? this.fileDetails.filter((f) => this.filterFile(f)) : this.fileDetails,
     );
-    readonly patchHeaderDiffOnly: boolean[] = $derived(findHeaderChangeOnlyPatches(this.fileDetails));
     readonly searchResults: Promise<SearchResults> = $derived(this.findSearchResults());
 
     private constructor() {
         // Auto-check all patch header diff only diffs
         $effect(() => {
-            for (let i = 0; i < this.patchHeaderDiffOnly.length; i++) {
-                if (this.patchHeaderDiffOnly[i] && this.checked[i] === undefined) {
+            for (let i = 0; i < this.fileDetails.length; i++) {
+                const details = this.fileDetails[i];
+                if (details.type !== "text") {
+                    continue;
+                }
+                if (details.patchHeaderDiffOnly && this.checked[i] === undefined) {
                     this.checked[i] = true;
                 }
             }

web/src/routes/+page.svelte

@@ -321,7 +321,7 @@
                                 {/if}
                             </div>
                         {/if}
-                        {#if !viewer.collapsed[index] && value.type === "text" && (!viewer.patchHeaderDiffOnly[index] || !globalOptions.omitPatchHeaderOnlyHunks)}
+                        {#if !viewer.collapsed[index] && value.type === "text" && (!value.patchHeaderDiffOnly || !globalOptions.omitPatchHeaderOnlyHunks)}
                             <div class="mb border-b">
                                 <ConciseDiffView
                                     patch={value.structuredPatch}

web/src/routes/FileHeader.svelte

@@ -28,6 +28,8 @@
             });
         }
     }
+
+    let patchHeaderDiffOnly = $derived(value.type === "text" && value.patchHeaderDiffOnly);
 </script>
 
 {#snippet fileName()}
@@ -101,11 +103,11 @@
     {/if}
     {@render fileName()}
     <div class="ms-0.5 ml-auto flex items-center gap-2">
-        {#if viewer.patchHeaderDiffOnly[index]}
+        {#if patchHeaderDiffOnly}
             <span class="rounded-sm bg-neutral-3 px-1.5">Patch-header-only diff</span>
         {/if}
         {@render actionsPopover()}
-        {#if !viewer.patchHeaderDiffOnly[index] || !globalOptions.omitPatchHeaderOnlyHunks || value.type === "image"}
+        {#if !patchHeaderDiffOnly || !globalOptions.omitPatchHeaderOnlyHunks || value.type === "image"}
             {@render collapseToggle()}
         {/if}
     </div>