Merge pull request #30 from troosan/avoid_double_call_to_function

Progi1984 · web-flow · commit 2caf52091f18 · 2019-05-13T17:39:09.000+02:00
Simplify calls to libxml_disable_entity_loader
diff --git a/src/Common/XMLReader.php b/src/Common/XMLReader.php
@@ -71,11 +71,11 @@ public function getDomFromZip($zipFile, $xmlFile)
      */
     public function getDomFromString($content)
     {
-        $originalLibXMLEntityValue = libxml_disable_entity_loader();
-        libxml_disable_entity_loader(true);
+        $originalLibXMLEntityValue = libxml_disable_entity_loader(true);
         $this->dom = new \DOMDocument();
         $this->dom->loadXML($content);
         libxml_disable_entity_loader($originalLibXMLEntityValue);
+
         return $this->dom;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -71,11 +71,11 @@ public function getDomFromZip($zipFile, $xmlFile)`
`71`	`71`	`*/`
`72`	`72`	`public function getDomFromString($content)`
`73`	`73`	`{`
`74`		`- $originalLibXMLEntityValue = libxml_disable_entity_loader();`
`75`		`- libxml_disable_entity_loader(true);`
	`74`	`+ $originalLibXMLEntityValue = libxml_disable_entity_loader(true);`
`76`	`75`	`$this->dom = new \DOMDocument();`
`77`	`76`	`$this->dom->loadXML($content);`
`78`	`77`	`libxml_disable_entity_loader($originalLibXMLEntityValue);`
	`78`	`+`
`79`	`79`	`return $this->dom;`
`80`	`80`	`}`
`81`	`81`