GH Actions: run tests on Windows too

For the `quicktest` and the `coverage` jobs, only select tests which are marked with `@group Windows` will be run.

For the "normal " `test` job, all tests will now be run on Windows too.

Author: jrfnl

.github/workflows/quicktest.yml

@@ -23,13 +23,14 @@ jobs:
   # These are basically the same builds as in the Test->Coverage workflow, but then without doing
   # the code-coverage.
   quicktest:
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.os }}
 
     strategy:
       matrix:
+        os: ['ubuntu-latest', 'windows-latest']
         php: ['5.4', '7.2', 'latest']
 
-    name: "QuickTest: PHP ${{ matrix.php }}"
+    name: "QuickTest: PHP ${{ matrix.php }} (${{ matrix.os == 'ubuntu-latest' && 'Linux' || 'Win'  }})"
 
     steps:
       - name: Checkout code
@@ -53,9 +54,14 @@ jobs:
       - name: 'PHPCS: set the path to PHP'
         run: php bin/phpcs --config-set php_path php
 
-      - name: 'PHPUnit: run the tests'
+      - name: 'PHPUnit: run the full test suite'
+        if: ${{ matrix.os != 'windows-latest' }}
         run: vendor/bin/phpunit tests/AllTests.php --no-coverage
 
+      - name: 'PHPUnit: run tests which may have different outcomes on Windows'
+        if: ${{ matrix.os == 'windows-latest' }}
+        run: vendor/bin/phpunit tests/AllTests.php --group Windows --no-coverage
+
       # Note: The code style check is run as an integration test.
       - name: 'PHPCS: check code style without cache, no parallel'
         run: php bin/phpcs --no-cache --parallel=1

.github/workflows/test.yml

@@ -88,6 +88,7 @@ jobs:
       # - custom_ini: Whether to run with specific custom ini settings to hit very specific
       #   code conditions.
       matrix:
+        os: ['ubuntu-latest', 'windows-latest']
         php: ['5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5']
         custom_ini: [false]
 
@@ -105,7 +106,7 @@ jobs:
           - php: '7.0'
             custom_ini: true
 
-    name: "PHP: ${{ matrix.php }} ${{ matrix.custom_ini && ' with custom ini settings' || '' }}"
+    name: "PHP: ${{ matrix.php }} ${{ matrix.custom_ini && ' with custom ini settings' || '' }} (${{ matrix.os == 'ubuntu-latest' && 'Linux' || 'Win'  }})"
 
     continue-on-error: ${{ matrix.php == '8.5' }}
 
@@ -162,7 +163,7 @@ jobs:
       - name: 'PHPCS: set the path to PHP'
         run: php bin/phpcs --config-set php_path php
 
-      - name: 'PHPUnit: run the tests without code coverage'
+      - name: 'PHPUnit: run the full test suite without code coverage'
         if: ${{ matrix.skip_tests != true }}
         run: vendor/bin/phpunit tests/AllTests.php --no-coverage
 
@@ -191,19 +192,20 @@ jobs:
         run: php phpcs.phar
 
   coverage:
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.os }}
 
     strategy:
       matrix:
+        os: ['ubuntu-latest', 'windows-latest']
+        php: ['5.4', '8.4']
+        custom_ini: [false]
+
         include:
-          - php: '5.4'
-            custom_ini: false
           - php: '7.2'
+            os: 'ubuntu-latest'
             custom_ini: true
-          - php: '8.4'
-            custom_ini: false
 
-    name: "Coverage: ${{ matrix.php }} ${{ matrix.custom_ini && ' with custom ini settings' || '' }}"
+    name: "Coverage: ${{ matrix.php }} ${{ matrix.custom_ini && ' with custom ini settings' || '' }} (${{ matrix.os == 'ubuntu-latest' && 'Linux' || 'Win'  }})"
 
     steps:
       - name: Checkout code
@@ -272,20 +274,28 @@ jobs:
         run: vendor/bin/phpunit --coverage-cache ./build/phpunit-cache --warm-coverage-cache
 
       - name: "Run the unit tests with code coverage (PHPUnit < 9.3)"
-        if: ${{ steps.phpunit_version.outputs.VERSION < '9.3' }}
+        if: ${{ matrix.os != 'windows-latest' && steps.phpunit_version.outputs.VERSION < '9.3' }}
         run: vendor/bin/phpunit tests/AllTests.php
 
       - name: "Run the unit tests with code coverage (PHPUnit 9.3+)"
-        if: ${{ steps.phpunit_version.outputs.VERSION >= '9.3' }}
+        if: ${{ matrix.os != 'windows-latest' && steps.phpunit_version.outputs.VERSION >= '9.3' }}
         run: vendor/bin/phpunit tests/AllTests.php --coverage-cache ./build/phpunit-cache
 
+      - name: "Run the unit tests which may have different outcomes on Windows with code coverage (PHPUnit < 9.3)"
+        if: ${{ matrix.os == 'windows-latest' && steps.phpunit_version.outputs.VERSION < '9.3' }}
+        run: vendor/bin/phpunit tests/AllTests.php --group Windows
+
+      - name: "Run the unit tests which may have different outcomes on Windows with code coverage (PHPUnit 9.3+)"
+        if: ${{ matrix.os == 'windows-latest' && steps.phpunit_version.outputs.VERSION >= '9.3' }}
+        run: vendor/bin/phpunit tests/AllTests.php --group Windows --coverage-cache ./build/phpunit-cache
+
       - name: Upload coverage results to Coveralls
         if: ${{ success() }}
         uses: coverallsapp/github-action@v2
         with:
           format: clover
           file: build/logs/clover.xml
-          flag-name: php-${{ matrix.php }}-custom-ini-${{ matrix.custom_ini }}
+          flag-name: os-${{ matrix.os }}-php-${{ matrix.php }}-custom-ini-${{ matrix.custom_ini }}
           parallel: true
 
   coveralls-finish: