Squiz/LowercasePHPFunctions: fix sniff to work with the PHP 8 identifier tokens

The existing unit tests already contain tests covering this change.

Includes updating two tests with code which is considered a parse error in PHP 8.0.
Handling that type of code is no longer supported by this sniff.

Author: jrfnl

src/Standards/Squiz/Sniffs/PHP/LowercasePHPFunctionsSniff.php

@@ -43,7 +43,10 @@ public function __construct()
      */
     public function register()
     {
-        return [T_STRING];
+        return [
+            T_STRING,
+            T_NAME_FULLY_QUALIFIED,
+        ];
 
     }//end register()
 
@@ -61,7 +64,11 @@ public function process(File $phpcsFile, $stackPtr)
     {
         $tokens = $phpcsFile->getTokens();
 
-        $content   = $tokens[$stackPtr]['content'];
+        $content = $tokens[$stackPtr]['content'];
+        if ($tokens[$stackPtr]['code'] === T_NAME_FULLY_QUALIFIED) {
+            $content = ltrim($content, '\\');
+        }
+
         $contentLc = strtolower($content);
         if ($content === $contentLc) {
             return;
@@ -93,7 +100,7 @@ public function process(File $phpcsFile, $stackPtr)
 
         if ($tokens[$next]['code'] !== T_OPEN_PARENTHESIS) {
             // Is this a use statement importing a PHP native function ?
-            if ($tokens[$next]['code'] !== T_NS_SEPARATOR
+            if ($tokens[$stackPtr]['code'] === T_STRING
                 && $tokens[$prev]['code'] === T_STRING
                 && $tokens[$prev]['content'] === 'function'
                 && $prevPrev !== false
@@ -120,19 +127,6 @@ public function process(File $phpcsFile, $stackPtr)
             return;
         }
 
-        if ($tokens[$prev]['code'] === T_NS_SEPARATOR) {
-            if ($prevPrev !== false
-                && ($tokens[$prevPrev]['code'] === T_STRING
-                || $tokens[$prevPrev]['code'] === T_NAMESPACE
-                || $tokens[$prevPrev]['code'] === T_NEW)
-            ) {
-                // Namespaced class/function, not an inbuilt function.
-                // Could potentially give false negatives for non-namespaced files
-                // when namespace\functionName() is encountered.
-                return;
-            }
-        }
-
         if ($tokens[$prev]['code'] === T_NEW) {
             // Object creation, not an inbuilt function.
             return;
@@ -158,7 +152,7 @@ public function process(File $phpcsFile, $stackPtr)
 
         $fix = $phpcsFile->addFixableError($error, $stackPtr, 'CallUppercase', $data);
         if ($fix === true) {
-            $phpcsFile->fixer->replaceToken($stackPtr, $contentLc);
+            $phpcsFile->fixer->replaceToken($stackPtr, strtolower($tokens[$stackPtr]['content']));
         }
 
     }//end process()

src/Standards/Squiz/Tests/PHP/LowercasePHPFunctionsUnitTest.inc

@@ -33,9 +33,9 @@ class ArrayUnique {}
 $sillyComments = strToLower /*comment*/ ($string);
 
 $callToGlobalFunction = \STR_REPEAT($a, 2);
-$callToGlobalFunction = \ /*comment*/ str_Repeat($a, 2);
+$callToGlobalFunction = \str_Repeat($a, 2);
 
-$callToNamespacedFunction = MyNamespace /* phpcs:ignore Standard */ \STR_REPEAT($a, 2);
+$callToNamespacedFunction = MyNamespace\STR_REPEAT($a, 2);
 $callToNamespacedFunction = namespace\STR_REPEAT($a, 2); // Could potentially be false negative.
 
 $filePath = new \File($path);

src/Standards/Squiz/Tests/PHP/LowercasePHPFunctionsUnitTest.inc.fixed

@@ -33,9 +33,9 @@ class ArrayUnique {}
 $sillyComments = strtolower /*comment*/ ($string);
 
 $callToGlobalFunction = \str_repeat($a, 2);
-$callToGlobalFunction = \ /*comment*/ str_repeat($a, 2);
+$callToGlobalFunction = \str_repeat($a, 2);
 
-$callToNamespacedFunction = MyNamespace /* phpcs:ignore Standard */ \STR_REPEAT($a, 2);
+$callToNamespacedFunction = MyNamespace\STR_REPEAT($a, 2);
 $callToNamespacedFunction = namespace\STR_REPEAT($a, 2); // Could potentially be false negative.
 
 $filePath = new \File($path);