Fixes #3 Handle unrecognizable types: multiple types, generics, arrays, …

Author: mnapoli

src/PhpDocReader/PhpDocReader.php

@@ -74,6 +74,11 @@ public function getPropertyClass(ReflectionProperty $property)
             return null;
         }
 
+        // Ignore types containing special characters ([], <> ...)
+        if (! preg_match('/^[a-zA-Z0-9\\\\]+$/', $type)) {
+            return null;
+        }
+
         $class = $property->getDeclaringClass();
 
         // If the class name is not fully qualified (i.e. doesn't start with a \)
@@ -175,6 +180,11 @@ public function getParameterClass(ReflectionParameter $parameter)
             return null;
         }
 
+        // Ignore types containing special characters ([], <> ...)
+        if (! preg_match('/^[a-zA-Z0-9\\\\]+$/', $type)) {
+            return null;
+        }
+
         $class = $parameter->getDeclaringClass();
 
         // If the class name is not fully qualified (i.e. doesn't start with a \)

tests/UnitTest/PhpDocReader/FixturesUnknownTypes/Class1.php

@@ -0,0 +1,40 @@
+<?php
+
+namespace UnitTest\PhpDocReader\FixturesUnknownTypes;
+
+class Class1
+{
+    /**
+     * @var
+     */
+    public $empty;
+
+    /**
+     * @var Foo[]
+     */
+    public $array;
+
+    /**
+     * @var array<Foo>
+     */
+    public $generics;
+
+    /**
+     * @var Foo|Bar
+     */
+    public $multiple;
+
+    /**
+     * @param            $empty
+     * @param Foo[]      $array
+     * @param array<Foo> $generics
+     * @param Foo|Bar    $multiple
+     */
+    public function foo(
+        $empty,
+        $array,
+        $generics,
+        $multiple
+    ) {
+    }
+} 

tests/UnitTest/PhpDocReader/UnknownTypesTest.php

@@ -0,0 +1,44 @@
+<?php
+
+namespace UnitTest\PhpDocReader;
+
+use PhpDocReader\PhpDocReader;
+use ReflectionParameter;
+
+/**
+ * @see https://github.com/mnapoli/PhpDocReader/issues/3
+ */
+class UnknownTypesTest extends \PHPUnit_Framework_TestCase
+{
+    /**
+     * @dataProvider typeProvider
+     */
+    public function testProperties($type)
+    {
+        $parser = new PhpDocReader();
+        $class = new \ReflectionClass('UnitTest\PhpDocReader\FixturesUnknownTypes\Class1');
+
+        $this->assertNull($parser->getPropertyClass($class->getProperty($type)));
+    }
+
+    /**
+     * @dataProvider typeProvider
+     */
+    public function testMethodParameters($type)
+    {
+        $parser = new PhpDocReader();
+        $parameter = new ReflectionParameter(array('UnitTest\PhpDocReader\FixturesUnknownTypes\Class1', 'foo'), $type);
+
+        $this->assertNull($parser->getParameterClass($parameter));
+    }
+
+    public function typeProvider()
+    {
+        return array(
+            'empty'    => array('empty'),
+            'array'    => array('array'),
+            'generics' => array('generics'),
+            'multiple' => array('multiple'),
+        );
+    }
+}