Replace deprecated YangInstanceIdentifier methods

Modernize usage of YangInstanceIdentifier, replacing deprecated
methods.
See:
Ie6a431deaca0a80b8ce1d16dad5a1b919c94f722

JIRA: LIGHTY-394
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>

Author: PeterSuna

lighty-netconf-device/src/main/java/io/lighty/netconf/device/NetconfDeviceImpl.java

@@ -125,7 +125,7 @@ void initDatastore(LogicalDatastoreType datastoreType, File initialData) {
             NormalizedNode initialDataBI = netconfDeviceServices.getXmlNodeConverter()
                     .deserialize(netconfDeviceServices.getRootInference(), reader);
             DOMDataTreeWriteTransaction writeTx = netconfDeviceServices.getDOMDataBroker().newWriteOnlyTransaction();
-            writeTx.put(datastoreType, YangInstanceIdentifier.empty(), initialDataBI);
+            writeTx.put(datastoreType, YangInstanceIdentifier.of(), initialDataBI);
             writeTx.commit().get(TimeoutUtil.TIMEOUT_MILLIS, TimeUnit.MILLISECONDS);
             final String dataTreeString = NormalizedNodes.toStringTree(initialDataBI);
             LOG.trace("Initial {} datastore data: {}", datastoreType, dataTreeString);

lighty-netconf-device/src/main/java/io/lighty/netconf/device/requests/DatastoreOutputRequestProcessor.java

@@ -48,7 +48,7 @@ protected List<NormalizedNode> getAllDataFromDatastore(LogicalDatastoreType data
         Optional<NormalizedNode> listData;
         try (DOMDataTreeReadTransaction domDataReadOnlyTransaction = domDataBroker.newReadOnlyTransaction()) {
             FluentFuture<Optional<NormalizedNode>> readData =
-                    domDataReadOnlyTransaction.read(datastoreType, YangInstanceIdentifier.empty());
+                    domDataReadOnlyTransaction.read(datastoreType, YangInstanceIdentifier.of());
             listData = readData.get(TimeoutUtil.TIMEOUT_MILLIS, TimeUnit.MILLISECONDS);
 
             if (listData.isPresent()) {

lighty-netconf-device/src/main/java/io/lighty/netconf/device/requests/EditConfigRequestProcessor.java

@@ -218,7 +218,7 @@ private void ensureParentsByMerge(final YangInstanceIdentifier path, final DOMDa
         while (it.hasNext()) {
             final PathArgument pathArgument = it.next();
             if (rootNormalizedPath == null) {
-                rootNormalizedPath = YangInstanceIdentifier.create(pathArgument);
+                rootNormalizedPath = YangInstanceIdentifier.of(pathArgument);
             }
 
             if (it.hasNext()) {
@@ -233,7 +233,7 @@ private void ensureParentsByMerge(final YangInstanceIdentifier path, final DOMDa
         Preconditions.checkArgument(rootNormalizedPath != null, "Empty path received");
 
         final NormalizedNode parentStructure = ImmutableNodes.fromInstanceId(effectiveModelContext,
-                YangInstanceIdentifier.create(normalizedPathWithoutChildArgs));
+                YangInstanceIdentifier.of(normalizedPathWithoutChildArgs));
         writeTx.merge(LogicalDatastoreType.CONFIGURATION, rootNormalizedPath, parentStructure);
     }
 
@@ -302,7 +302,7 @@ private static YangInstanceIdentifier getYangInstanceIdentifier(final List<QName
             contextNode = requireNonNull(((DataSchemaContext.Composite) contextNode).childByQName(currentQname));
 
             while (contextNode instanceof PathMixin) {
-                targetIdentifier = YangInstanceIdentifier.create(targetIdentifier.getPathArguments())
+                targetIdentifier = YangInstanceIdentifier.of(targetIdentifier.getPathArguments())
                         .node(contextNode.pathStep());
                 contextNode = requireNonNull(((DataSchemaContext.Composite) contextNode).childByQName(currentQname));
             }
@@ -313,10 +313,10 @@ private static YangInstanceIdentifier getYangInstanceIdentifier(final List<QName
                 final MapEntryNode next = ((MapNode) findNode.get()).body().iterator().next();
                 final Map<QName, Object> keyValues = next.name().asMap();
                 targetIdentifier = YangInstanceIdentifier
-                        .builder(YangInstanceIdentifier.create(targetIdentifier.getPathArguments()))
+                        .builder(YangInstanceIdentifier.of(targetIdentifier.getPathArguments()))
                         .nodeWithKey(contextNode.dataSchemaNode().getQName(), keyValues).build();
             } else {
-                targetIdentifier = YangInstanceIdentifier.create(targetIdentifier.getPathArguments())
+                targetIdentifier = YangInstanceIdentifier.of(targetIdentifier.getPathArguments())
                         .node(contextNode.getPathStep());
             }
         }