Skip to content

Commit 3184eb2

Browse files
author
Martii
committed
nofollow on all sensitive panels links
* Some browser toolbars may try to index these while logged in... the "or something" would usually be in robots.txt but #135 still exists and routes are still in flux so this is what we are left with. Closes #340
1 parent dd56a3a commit 3184eb2

File tree

8 files changed

+18
-18
lines changed

8 files changed

+18
-18
lines changed

‎views/includes/groupAdminToolsPanel.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
</div>
88
</div>
99
<div class="panel-body">
10-
<a href="/admin/json?model=Group&id={{{group._id}}}" class="btn btn-link col-xs-12"><i class="fa fa-database"></i> Raw JSON Data</a>
10+
<a rel="nofollow" href="/admin/json?model=Group&id={{{group._id}}}" class="btn btn-link col-xs-12"><i class="fa fa-database"></i> Raw JSON Data</a>
1111
</div>
1212
</div>
1313
{{/adminTools}}

‎views/includes/scriptAuthorToolsPanel.html‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
</div>
66
<div class="panel-body">
77
<ul class="nav nav-pills nav-justified">
8-
<li><a href="{{{script.scriptEditMetadataPageUrl}}}"><i class="fa fa-edit"></i> Edit Script Info</a></li>
9-
<li><a href="{{{script.scriptEditSourcePageUrl}}}"><i class="fa fa-file-text"></i> Edit Script</a></li>
8+
<li><a rel="nofollow" href="{{{script.scriptEditMetadataPageUrl}}}"><i class="fa fa-edit"></i> Edit Script Info</a></li>
9+
<li><a rel="nofollow" href="{{{script.scriptEditSourcePageUrl}}}"><i class="fa fa-file-text"></i> Edit Script</a></li>
1010
</ul>
1111

1212
<hr>
@@ -22,7 +22,7 @@ <h4>Installs per Version <small>since <time>2 Sept 2014</time></small></h4>
2222
</div>
2323
<div class="panel-body">
2424
<ul class="nav nav-pills nav-justified">
25-
<li><a href="#" data-toggle="modal" data-target="#deleteScriptModal"><i class="fa fa-trash-o"></i> Delete Script</a></li>
25+
<li><a rel="nofollow" href="#" data-toggle="modal" data-target="#deleteScriptModal"><i class="fa fa-trash-o"></i> Delete Script</a></li>
2626
</ul>
2727
</div>
2828
</div>

‎views/includes/scriptModToolsPanel.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
{{> includes/flagModelSnippet.html }}
1212
{{/script}}
1313
<ul class="nav nav-pills nav-justified">
14-
<li><a href="#" data-toggle="modal" data-target="#removeScriptModal" class="{{^canRemove}}disabled{{/canRemove}}"><i class="fa fa-ban"></i> Remove Script</a></li>
14+
<li><a rel="nofollow" href="#" data-toggle="modal" data-target="#removeScriptModal" class="{{^canRemove}}disabled{{/canRemove}}"><i class="fa fa-ban"></i> Remove Script</a></li>
1515
</ul>
1616
</div>
1717
</div>

‎views/includes/scriptUserToolsPanel.html‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
<div class="panel-body">
33
<div class="row">
44
<div class="pull-left vote-area">
5-
<a href="{{^votedUp}}{{{voteUpUrl}}}{{/votedUp}}{{#votedUp}}{{{unvoteUrl}}}{{/votedUp}}" class="btn-vote {{^voteable}}disabled{{/voteable}} {{#votedUp}}active{{/votedUp}}"><i class="fa fa-2x fa-caret-up"></i></a>
6-
<a href="{{^votedDown}}{{{voteDownUrl}}}{{/votedDown}}{{#votedDown}}{{{unvoteUrl}}}{{/votedDown}}" class="btn-vote {{^voteable}}disabled{{/voteable}} {{#votedDown}}active{{/votedDown}}"><i class="fa fa-2x fa-caret-down"></i></a>
5+
<a rel="nofollow" href="{{^votedUp}}{{{voteUpUrl}}}{{/votedUp}}{{#votedUp}}{{{unvoteUrl}}}{{/votedUp}}" class="btn-vote {{^voteable}}disabled{{/voteable}} {{#votedUp}}active{{/votedUp}}"><i class="fa fa-2x fa-caret-up"></i></a>
6+
<a rel="nofollow" href="{{^votedDown}}{{{voteDownUrl}}}{{/votedDown}}{{#votedDown}}{{{unvoteUrl}}}{{/votedDown}}" class="btn-vote {{^voteable}}disabled{{/voteable}} {{#votedDown}}active{{/votedDown}}"><i class="fa fa-2x fa-caret-down"></i></a>
77
</div>
88
<p><i class="fa fa-fw fa-signal"></i> <b>Rating:</b> {{script.rating}}</p>
99
<div class="progress">
@@ -12,9 +12,9 @@
1212
</div>
1313
</div>
1414
<ul class="nav nav-pills nav-justified">
15-
<li><a href="{{{favoriteUrl}}}" class="{{^canFavorite}}disabled{{/canFavorite}}"><i class="fa fa-star{{^upvoted}}-o{{/upvoted}}"></i> Favorite</a></li>
16-
<li><a href="{{{flagUrl}}}" class="{{^canFlag}}disabled{{/canFlag}}"><i class="fa fa-flag{{^flagged}}-o{{/flagged}}"></i> {{#flagged}}Unflag{{/flagged}}{{^flagged}}Flag{{/flagged}}</a></li>
17-
<li><a href="{{forkUrl}}" class="{{^canFork}}disabled{{/canFork}}"><i class="fa fa-code-fork"></i> Fork</a></li>
15+
<li><a rel="nofollow" href="{{{favoriteUrl}}}" class="{{^canFavorite}}disabled{{/canFavorite}}"><i class="fa fa-star{{^upvoted}}-o{{/upvoted}}"></i> Favorite</a></li>
16+
<li><a rel="nofollow" href="{{{flagUrl}}}" class="{{^canFlag}}disabled{{/canFlag}}"><i class="fa fa-flag{{^flagged}}-o{{/flagged}}"></i> {{#flagged}}Unflag{{/flagged}}{{^flagged}}Flag{{/flagged}}</a></li>
17+
<li><a rel="nofollow" href="{{forkUrl}}" class="{{^canFork}}disabled{{/canFork}}"><i class="fa fa-code-fork"></i> Fork</a></li>
1818
</ul>
1919
</div>
2020
</div>

‎views/includes/userAdminToolsPanel.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
<input type="submit" class="col-sm-2 btn btn-default" value="Save">
2121
</div>
2222
</form>
23-
<a href="/admin/json?model=User&id={{{user._id}}}" class="btn btn-link col-xs-12"><i class="fa fa-database"></i> Raw JSON Data</a>
24-
{{#adminTools.authAsUserUrl}}<a href="{{{adminTools.authAsUserUrl}}}" class="btn btn-link col-xs-12"><i class="fa fa-sign-in"></i> Auth As This User</a>{{/adminTools.authAsUserUrl}}
23+
<a rel="nofollow" href="/admin/json?model=User&id={{{user._id}}}" class="btn btn-link col-xs-12"><i class="fa fa-database"></i> Raw JSON Data</a>
24+
{{#adminTools.authAsUserUrl}}<a rel="nofollow" href="{{{adminTools.authAsUserUrl}}}" class="btn btn-link col-xs-12"><i class="fa fa-sign-in"></i> Auth As This User</a>{{/adminTools.authAsUserUrl}}
2525
</div>
2626
</div>
2727
{{/adminTools}}

‎views/includes/userModToolsPanel.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
{{> includes/flagModelSnippet.html }}
1212
{{/user}}
1313
<ul class="nav nav-pills nav-justified">
14-
<li><a href="#" data-toggle="modal" data-target="#removeUserModal" class="{{^canRemove}}disabled{{/canRemove}}"><i class="fa fa-ban"></i> Remove User</a></li>
14+
<li><a rel="nofollow" href="#" data-toggle="modal" data-target="#removeUserModal" class="{{^canRemove}}disabled{{/canRemove}}"><i class="fa fa-ban"></i> Remove User</a></li>
1515
</ul>
1616
</div>
1717
</div>

‎views/includes/userToolsPanel.html‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22
<div class="panel panel-default">
33
<div class="panel-body">
44
<ul class="nav nav-pills nav-justified">
5-
<li><a href="{{{user.userEditProfilePageUrl}}}" class="{{^user.userEditProfilePageUrl}}disabled{{/user.userEditProfilePageUrl}}"><i class="fa fa-user"></i> Edit Profile</a></li>
6-
<li><a href="/user/preferences"><i class="fa fa-cogs"></i> Preferences</a></li>
5+
<li><a rel="nofollow" href="{{{user.userEditProfilePageUrl}}}" class="{{^user.userEditProfilePageUrl}}disabled{{/user.userEditProfilePageUrl}}"><i class="fa fa-user"></i> Edit Profile</a></li>
6+
<li><a rel="nofollow" href="/user/preferences"><i class="fa fa-cogs"></i> Preferences</a></li>
77
</ul>
88
<ul class="nav nav-pills nav-justified">
9-
<li><a href="/user/add/scripts"><i class="fa fa-file-code-o"></i> Add Script</a></li>
10-
<li><a href="/user/add/lib"><i class="fa fa-file-excel-o"></i> Add Library</a></li>
9+
<li><a rel="nofollow" href="/user/add/scripts"><i class="fa fa-file-code-o"></i> Add Script</a></li>
10+
<li><a rel="nofollow" href="/user/add/lib"><i class="fa fa-file-excel-o"></i> Add Library</a></li>
1111
</ul>
1212
</div>
1313
</div>

‎views/includes/userUserToolsPanel.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<div class="panel panel-default">
22
<div class="panel-body">
33
<ul class="nav nav-pills nav-justified">
4-
<li><a href="{{{flagUrl}}}" class="{{^canFlag}}disabled{{/canFlag}}"><i class="fa fa-flag{{^flagged}}-o{{/flagged}}"></i> {{#flagged}}Unflag{{/flagged}}{{^flagged}}Flag{{/flagged}}</a></li>
4+
<li><a rel="nofollow" href="{{{flagUrl}}}" class="{{^canFlag}}disabled{{/canFlag}}"><i class="fa fa-flag{{^flagged}}-o{{/flagged}}"></i> {{#flagged}}Unflag{{/flagged}}{{^flagged}}Flag{{/flagged}}</a></li>
55
</ul>
66
</div>
77
</div>

0 commit comments

Comments
 (0)