refactor: remove whitelisted users logic from AuthService

Author: tomast1337

server/src/auth/auth.module.ts

@@ -96,12 +96,6 @@ export class AuthModule {
           useFactory: (configService: ConfigService) =>
             configService.getOrThrow<string>('JWT_REFRESH_EXPIRES_IN'),
         },
-        {
-          inject: [ConfigService],
-          provide: 'WHITELISTED_USERS',
-          useFactory: (configService: ConfigService) =>
-            configService.getOrThrow<string>('WHITELISTED_USERS'),
-        },
         {
           inject: [ConfigService],
           provide: 'MAGIC_LINK_SECRET',

server/src/auth/auth.service.ts

@@ -34,8 +34,6 @@ export class AuthService {
     private readonly JWT_REFRESH_SECRET: string,
     @Inject('JWT_REFRESH_EXPIRES_IN')
     private readonly JWT_REFRESH_EXPIRES_IN: string,
-    @Inject('WHITELISTED_USERS')
-    private readonly WHITELISTED_USERS: string,
     @Inject('APP_DOMAIN')
     private readonly APP_DOMAIN?: string,
   ) {}
@@ -83,10 +81,6 @@ export class AuthService {
       profileImage: user.photos[0].value,
     };
 
-    if (!(await this.verifyWhitelist(profile.username))) {
-      return res.redirect(this.FRONTEND_URL + '/login');
-    }
-
     // verify if user exists
     const user_registered = await this.verifyAndGetUser(profile);
 
@@ -123,23 +117,6 @@ export class AuthService {
     return user_registered;
   }
 
-  private async verifyWhitelist(username: string) {
-    const whitelist = this.WHITELISTED_USERS;
-
-    if (whitelist.length === 0) {
-      return true;
-    }
-
-    if (whitelist.includes(username.toLowerCase())) {
-      this.logger.log(`User ${username} is whitelisted; approving login`);
-      return true;
-    }
-
-    this.logger.log(`User ${username} is not whitelisted; rejecting login`);
-
-    return false;
-  }
-
   public async githubLogin(req: Request, res: Response) {
     const user = req.user as GithubAccessToken;
     const { profile } = user;
@@ -156,10 +133,6 @@ export class AuthService {
 
     const email = response.data.filter((email) => email.primary)[0].email;
 
-    if (!(await this.verifyWhitelist(profile.username))) {
-      return res.redirect(this.FRONTEND_URL + '/login');
-    }
-
     const user_registered = await this.verifyAndGetUser({
       username: profile.username,
       email: email,
@@ -180,10 +153,6 @@ export class AuthService {
       profileImage: profilePictureUrl,
     };
 
-    if (!(await this.verifyWhitelist(profile.username))) {
-      return res.redirect(this.FRONTEND_URL + '/login');
-    }
-
     // verify if user exists
     const user_registered = await this.verifyAndGetUser(profile);