Skip to content

Fix #1216 and the fallback theme #4756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix #1216 and the fallback theme #4756

wants to merge 3 commits into from

Conversation

@Hanmac
Copy link
Contributor

@Hanmac Hanmac commented Apr 17, 2025

Description (*)

Done by Suggestion of #1216 (comment)

Related Pull Requests

  • see OpenMage/magento-lts#<issue_number>

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@Hanmac Hanmac added Component: Adminhtml Relates to Mage_Adminhtml XML Layout labels Apr 17, 2025
@github-actions github-actions bot added Component: PayPal Relates to Mage_Paypal Component: Core Relates to Mage_Core Component: Catalog Relates to Mage_Catalog Template : admin Relates to admin template Component: Cms Relates to Mage_Cms Component: Reports Relates to Mage_Reports Component: AdminNotification Relates to Mage_AdminNotification Component: Sales Relates to Mage_Sales Component: Usa Relates to Mage_Usa Component: Customer Relates to Mage_Customer Component: Eav Relates to Mage_Eav Component: Page Relates to Mage_Page Component: Api PageRelates to Mage_Api Component: Captcha Relates to Mage_Captcha Component: Tag Relates to Mage_Tag Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: Admin Relates to Mage_Admin Component: Widget Relates to Mage_Widget Component: Weee Relates to Mage_Weee Component: Tax Relates to Mage_Tax Component: Review Relates to Mage_Review Component: Rating Relates to Mage_Rating Component: Payment Relates to Mage_Payment Component: Oauth Relates to Mage_Oauth Component: Newsletter Relates to Mage_Newsletter Component: Index Relates to Mage_Index Component: Giftmessage Relates to Mage_Giftmessage and removed XML Layout labels Apr 17, 2025
@github-actions github-actions bot added Component: CatalogSearch Relates to Mage_CatalogSearch Component: Authorizenet Relates to Mage_Authorizenet Component: Centinel Relates to Mage_Centinel Component: Dataflow Relates to Mage_Dataflow Component: Rss Relates to Mage_Rss Component: Paygate Relates to Mage_Paygate phpstan labels Apr 17, 2025
@Hanmac
Copy link
Contributor Author

Hanmac commented Apr 17, 2025

just ignore sonar ;P

@Hanmac
Copy link
Contributor Author

Hanmac commented Apr 17, 2025

Kudos to @ericthehacker for the Original Version:
https://github.com/ericthehacker/magento-themefallbackfix

@sreichel sreichel added this to the 20.15.0 milestone May 8, 2025
@Hanmac Hanmac force-pushed the designLayoutUpdates branch from 7964e8c to 04d1503 Compare May 15, 2025 11:28
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 15, 2025 •
edited
Loading

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots
13.2% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Hanmac Hanmac marked this pull request as ready for review May 15, 2025 12:50
@sreichel sreichel modified the milestones: 20.15.0, 20.16.0 Jul 5, 2025
sreichel
sreichel reviewed Jul 6, 2025
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
13.6% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@sreichel
Copy link
Contributor

sreichel commented Aug 8, 2025

I'll test again as soon i am okay ....

My dog died last week and I need some days for my own. :(

@theroch
Copy link
Contributor

theroch commented Aug 9, 2025

Hey @sreichel,

I'm very sorry about your dog, I know he meant a lot to you.
Take the time you need.
We'll have a colleague at our company test the PR again with the current code.

@addison74
Copy link
Contributor

addison74 commented Aug 11, 2025

My dog died last week and I need some days for my own. :(

@sreichel - I'm so sorry for your loss. I know how much this dog meant to you. I hope you get over it well. Take care of yourself.

@sreichel
Copy link
Contributor

sreichel commented Oct 2, 2025

@Hanmac please update phpstan baseline to fix the conflict.

@Hanmac Hanmac force-pushed the designLayoutUpdates branch from 5fcdda3 to 86d6044 Compare October 2, 2025 07:58
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots
13.6% Duplication on New Code (required ≤ 3%)
E Security Rating on New Code (required ≥ A)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@sreichel sreichel modified the milestones: 20.16.0, 20.17.0 Oct 22, 2025
@Hanmac Hanmac force-pushed the designLayoutUpdates branch from 33e5a3f to 431b0dd Compare November 25, 2025 15:50
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 26, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
13.6% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sreichel sreichel sreichel left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: AdminNotification Relates to Mage_AdminNotification Component: Api PageRelates to Mage_Api Component: Api2 Relates to Mage_Api2 Component: Authorizenet Relates to Mage_Authorizenet Component: Bundle Relates to Mage_Bundle Component: Captcha Relates to Mage_Captcha Component: Catalog Relates to Mage_Catalog Component: CatalogSearch Relates to Mage_CatalogSearch Component: Centinel Relates to Mage_Centinel Component: Cms Relates to Mage_Cms Component: Core Relates to Mage_Core Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: Giftmessage Relates to Mage_Giftmessage Component: ImportExport Relates to Mage_ImportExport Component: Index Relates to Mage_Index Component: Media Relates to Mage_Media Component: Newsletter Relates to Mage_Newsletter Component: Oauth Relates to Mage_Oauth Component: Page Relates to Mage_Page Component: Paygate Relates to Mage_Paygate Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: Rating Relates to Mage_Rating Component: Reports Relates to Mage_Reports Component: Review Relates to Mage_Review Component: Rss Relates to Mage_Rss Component: Sales Relates to Mage_Sales Component: Tag Relates to Mage_Tag Component: Tax Relates to Mage_Tax Component: Usa Relates to Mage_Usa Component: Weee Relates to Mage_Weee Component: Widget Relates to Mage_Widget phpstan Template : admin Relates to admin template

Projects

None yet

Milestone

20.17.0

Development

Successfully merging this pull request may close these issues.

Admin theme changed by default config value

4 participants

@Hanmac @sreichel @theroch @addison74