chore: improved names and lint fixes

Author: jkasten2

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/debug/internal/crash/IOneSignalCrashReporter.kt

@@ -1,5 +1,5 @@
 package com.onesignal.debug.internal.crash
 
 internal interface IOneSignalCrashReporter {
-    suspend fun sendCrash(thread: Thread, throwable: Throwable)
+    suspend fun saveCrash(thread: Thread, throwable: Throwable)
 }

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/debug/internal/crash/OneSignalCrashHandler.kt

@@ -25,8 +25,9 @@ internal class OneSignalCrashHandler(
         // more than once. This would only happen if there was another crash
         // handler and was faulty in a specific way.
         synchronized(seenThrowables) {
-            if (seenThrowables.contains(throwable))
+            if (seenThrowables.contains(throwable)) {
                 return
+            }
             seenThrowables.add(throwable)
         }
 
@@ -55,8 +56,8 @@ internal class OneSignalCrashHandler(
          *
          * NOTE: addShutdownHook() isn't a workaround as it doesn't fire for
          * Process.killProcess, which KillApplicationHandler calls.
-        */
-        runBlocking { _crashReporter.sendCrash(thread, throwable) }
+         */
+        runBlocking { _crashReporter.saveCrash(thread, throwable) }
         existingHandler?.uncaughtException(thread, throwable)
     }
 }

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/debug/internal/logging/otel/OneSignalOpenTelemetry.kt

@@ -26,22 +26,23 @@ internal abstract class OneSignalOpenTelemetryBase(
     private val _osPerEventFields: OneSignalOtelFieldsPerEvent,
 ) : IOneSignalOpenTelemetry {
     private val lock = Any()
-    private var sdk: OpenTelemetrySdk? = null
+    private var sdkCachedValue: OpenTelemetrySdk? = null
+
     protected suspend fun getSdk(): OpenTelemetrySdk {
         val attributes = _osTopLevelFields.getAttributes()
         synchronized(lock) {
-            var localSdk = sdk
+            var localSdk = sdkCachedValue
             if (localSdk != null) {
                 return localSdk
             }
 
             localSdk = getSdkInstance(attributes)
-            sdk = localSdk
+            sdkCachedValue = localSdk
             return localSdk
         }
     }
 
-     protected abstract fun getSdkInstance(attributes: Map<String, String>): OpenTelemetrySdk
+    protected abstract fun getSdkInstance(attributes: Map<String, String>): OpenTelemetrySdk
 
     override suspend fun forceFlush(): CompletableResultCode {
         val sdkLoggerProvider = getSdk().sdkLoggerProvider
@@ -53,7 +54,8 @@ internal abstract class OneSignalOpenTelemetryBase(
     }
 
     override suspend fun getLogger(): LogRecordBuilder =
-        getSdk().sdkLoggerProvider
+        getSdk()
+            .sdkLoggerProvider
             .loggerBuilder("loggerBuilder")
             .build()
             .logRecordBuilder()
@@ -106,6 +108,5 @@ internal class OneSignalOpenTelemetryCrashLocal(
                     _crashPathProvider.path,
                     _crashPathProvider.minFileAgeForReadMillis,
                 )
-            )
-            .build()
+            ).build()
 }

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/debug/internal/logging/otel/attributes/OneSignalOtelFieldsPerEvent.kt

@@ -20,8 +20,7 @@ internal class OneSignalOtelFieldsPerEvent(
             .putIfValueNotNull(
                 "$OS_OTEL_NAMESPACE.onesignal_id",
                 onesignalId
-            )
-            .putIfValueNotNull(
+            ).putIfValueNotNull(
                 "$OS_OTEL_NAMESPACE.push_subscription_id",
                 subscriptionId
             )

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/debug/internal/logging/otel/config/OtelConfigRemoteOneSignal.kt

@@ -27,7 +27,7 @@ internal class OtelConfigRemoteOneSignal {
     }
 
     object SdkLoggerProviderConfig {
-        // TODO: Switch to sdklogs.onesignal.com
+        // TODO: Switch to https://sdklogs.onesignal.com:443/sdk/otel
         const val BASE_URL = "https://api.honeycomb.io:443"
 
         @RequiresApi(Build.VERSION_CODES.O)
@@ -40,7 +40,7 @@ internal class OtelConfigRemoteOneSignal {
                 .setResource(resource)
                 .addLogRecordProcessor(
                     OtelConfigShared.LogRecordProcessorConfig.batchLogRecordProcessor(
-                    HttpRecordBatchExporter.create(extraHttpHeaders)
+                        HttpRecordBatchExporter.create(extraHttpHeaders)
                     )
                 ).setLogLimits(LogLimitsConfig::logLimits)
                 .build()

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/debug/internal/logging/otel/crash/OneSignalCrashReporterOtel.kt

@@ -13,10 +13,9 @@ internal class OneSignalCrashReporterOtel(
         private const val OTEL_EXCEPTION_TYPE = "exception.type"
         private const val OTEL_EXCEPTION_MESSAGE = "exception.message"
         private const val OTEL_EXCEPTION_STACKTRACE = "exception.stacktrace"
-
     }
 
-    override suspend fun sendCrash(thread: Thread, throwable: Throwable) {
+    override suspend fun saveCrash(thread: Thread, throwable: Throwable) {
         val attributesBuilder =
             Attributes
                 .builder()
@@ -28,7 +27,8 @@ internal class OneSignalCrashReporterOtel(
                 .put("$OS_OTEL_NAMESPACE.exception.thread.name", thread.name)
                 .build()
 
-        _openTelemetry.getLogger()
+        _openTelemetry
+            .getLogger()
             .setAllAttributes(attributesBuilder)
             .setSeverity(Severity.FATAL)
             .emit()