Improve readability for world bypass permission

TheMeinerLP · TheMeinerLP · commit 5a695faa228b · 2024-06-12T22:51:56.000+02:00
diff --git a/src/main/java/net/onelitefeather/bettergopaint/listeners/InteractListener.java b/src/main/java/net/onelitefeather/bettergopaint/listeners/InteractListener.java
@@ -85,7 +85,9 @@ public void onClick(PlayerInteractEvent event) {
             return;
         }
 
-        if (!player.hasPermission(BetterGoPaint.WORLD_BYPASS_PERMISSION) && Settings.settings().GENERIC.DISABLED_WORLDS
+        final boolean hasNotWorldBaypassPermission = !player.hasPermission(BetterGoPaint.WORLD_BYPASS_PERMISSION);
+
+        if (hasNotWorldBaypassPermission && Settings.settings().GENERIC.DISABLED_WORLDS
                 .contains(location.getWorld().getName())) {
             return;
         }

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,9 @@ public void onClick(PlayerInteractEvent event) {`
`85`	`85`	`return;`
`86`	`86`	`}`
`87`	`87`
`88`		`- if (!player.hasPermission(BetterGoPaint.WORLD_BYPASS_PERMISSION) && Settings.settings().GENERIC.DISABLED_WORLDS`
	`88`	`+ final boolean hasNotWorldBaypassPermission = !player.hasPermission(BetterGoPaint.WORLD_BYPASS_PERMISSION);`
	`89`	`+`
	`90`	`+ if (hasNotWorldBaypassPermission && Settings.settings().GENERIC.DISABLED_WORLDS`
`89`	`91`	`.contains(location.getWorld().getName())) {`
`90`	`92`	`return;`
`91`	`93`	`}`