Skip to content

Conversation

@Rick-Kirkham
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
New sample? no
Related issues? none

What's in this Pull Request?

The add-in only manifest is replaced with the unified manifest in the Outlook NAA sample, and associated changes in the package.json and webpack.config.js.

Guidance

@Rick-Kirkham Rick-Kirkham added the Do Not Merge This PR has additional work or review required before it is ready to merge. label Jun 12, 2025
@Rick-Kirkham Rick-Kirkham removed the Do Not Merge This PR has additional work or review required before it is ready to merge. label Jul 12, 2025
Copy link
Member

@davidchesnut davidchesnut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the extra package-lock.json files are unnecessary as they shouldn't differ based on which manifest type you use.

@Rick-Kirkham
Copy link
Contributor Author

I don't think the extra package-lock.json files are unnecessary as they shouldn't differ based on which manifest type you use.

Good idea. Done.

Copy link
Member

@davidchesnut davidchesnut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Rick-Kirkham Rick-Kirkham merged commit 7725e10 into main Dec 6, 2025
1 check passed
@Rick-Kirkham Rick-Kirkham deleted the convert-outlook-naa-unified-manifest branch December 6, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants