code formatting and fixes

Author: MrRefactoring

src/services/formDataService/formDataService.ts

@@ -45,7 +45,7 @@ export class FormDataService {
 
       this.formData.append('file', file);
     } else {
-      throw new Error('Invalid value'); // todo
+      throw new Error('Invalid value'); // todo error handling
     }
   }
 
@@ -66,8 +66,6 @@ export class FormDataService {
         totalSize += value.size;
       } else if (ArrayBuffer.isView(value) || value instanceof ArrayBuffer) {
         totalSize += value.byteLength;
-      } else if (typeof Buffer !== 'undefined' && Buffer.isBuffer(value)) {
-        totalSize += value.length;
       } else if (value === null || value === undefined) {
         continue;
       } else {

src/version2/issueAttachments.ts

@@ -2,7 +2,7 @@ import type * as Models from './models';
 import type * as Parameters from './parameters';
 import type { Client } from '../clients';
 import type { Callback } from '../callback';
-import type { Request } from '../requestConfig';
+import type { Request } from '../request';
 import { FormDataService } from '../services/formDataService';
 
 export class IssueAttachments {
@@ -380,10 +380,7 @@ export class IssueAttachments {
    *   to view the issue.
    */
   async addAttachment<T = Models.Attachment[]>(parameters: Parameters.AddAttachment, callback?: never): Promise<T>;
-  async addAttachment<T = Models.Attachment[]>(
-    parameters: Parameters.AddAttachment,
-    callback?: Callback<T>,
-  ): Promise<void | T> {
+  async addAttachment<T = Models.Attachment[]>(parameters: Parameters.AddAttachment): Promise<void | T> {
     const formDataService = new FormDataService();
     const attachments = Array.isArray(parameters.attachment) ? parameters.attachment : [parameters.attachment];
 
@@ -396,18 +393,18 @@ export class IssueAttachments {
       ),
     );
 
-    const config: RequestConfig = {
+    const config: Request = {
       url: `/rest/api/2/issue/${parameters.issueIdOrKey}/attachments`,
       method: 'POST',
       headers: {
         'X-Atlassian-Token': 'no-check',
         'Content-Type': 'multipart/form-data',
       },
-      data: formDataService.formData,
-      maxBodyLength: Infinity,
-      maxContentLength: Infinity,
+      body: formDataService.formData,
+      // maxBodyLength: Infinity, // todo needed?
+      // maxContentLength: Infinity, // todo needed?
     };
 
-    return this.client.sendRequest(config, callback);
+    return this.client.sendRequest(config);
   }
 }

tests/integration/version2/issueAttachments.test.ts

@@ -1,6 +1,6 @@
 import * as fs from 'node:fs';
 import { open } from 'node:fs/promises';
-import { afterAll, beforeAll, describe, test, it } from 'vitest';
+import { afterAll, beforeAll, describe, test, it, expect } from 'vitest';
 import type { Attachment, Issue } from '@jirajs/version2/models';
 import { Constants } from '@tests/integration/constants';
 import { cleanupEnvironment, getVersion2Client, prepareEnvironment } from '@tests/integration/utils';