Defining pin bases and counts. (Refactoring)

Author: MrGreensWorkshop

README.md

@@ -33,6 +33,7 @@ I usually use old or junk parts on my projects to reduce electronic waste and su
 - POST code output to the LEDs
 - Filter LPC I/0 frame with start, cycle/dir and address
 - Abort frame support
+- Defining pin bases and counts (Refactoring)
 
 ### Compilation
 

src/lpc_bus_sniffer.pio

@@ -56,15 +56,15 @@ push                             ; Push to get the DATA value on terminal.
 
 //#define SIDE_PIN 26   // For debugging
 
-void lpc_bus_sniffer_program_init(PIO pio, uint sm, uint offset, uint lpc_bus_pin_base, uint led_pin_base) {
+void lpc_bus_sniffer_program_init(PIO pio, uint sm, uint offset, uint lpc_bus_pin_base, uint lpc_bus_pin_count, uint led_pin_base, uint led_pin_count) {
    pio_sm_config c = lpc_bus_sniffer_program_get_default_config(offset);
 
    // Connect the GPIOs to selected PIO block
-   for(uint i = lpc_bus_pin_base; i < lpc_bus_pin_base + 6; i++) {
+   for(uint i = lpc_bus_pin_base; i < lpc_bus_pin_base + lpc_bus_pin_count; i++) {
       pio_gpio_init(pio, i);
    }
 
-   for(uint i = led_pin_base; i < led_pin_base + 8; i++) {
+   for(uint i = led_pin_base; i < led_pin_base + led_pin_count; i++) {
       pio_gpio_init(pio, i);
    }
 
@@ -73,10 +73,10 @@ void lpc_bus_sniffer_program_init(PIO pio, uint sm, uint offset, uint lpc_bus_pi
 #endif
 
    // Set the selected pin directions for the selected 6 pins. LAD[0-3] + LCLK + LFRAME (false: in)
-   pio_sm_set_consecutive_pindirs(pio, sm, lpc_bus_pin_base, 6, false);
+   pio_sm_set_consecutive_pindirs(pio, sm, lpc_bus_pin_base, lpc_bus_pin_count, false);
 
    // Set the selected pin directions for the selected 8 pins. LED[0-8] (true: out)
-   pio_sm_set_consecutive_pindirs(pio, sm, led_pin_base, 8, true);
+   pio_sm_set_consecutive_pindirs(pio, sm, led_pin_base, led_pin_count, true);
 
 #ifdef SIDE_PIN
    // Set the selected pin direction for the selected 1 pin. SIDE_PIN (true: out)
@@ -101,7 +101,7 @@ void lpc_bus_sniffer_program_init(PIO pio, uint sm, uint offset, uint lpc_bus_pi
    sm_config_set_in_pins(&c, lpc_bus_pin_base);
 
    // Set 'OUT' base pin. To drive the LED's.
-   sm_config_set_out_pins(&c, led_pin_base, 8);
+   sm_config_set_out_pins(&c, led_pin_base, led_pin_count);
 
    // Set 'JMP' pin. To read the LFRAME.
    sm_config_set_jmp_pin(&c, lpc_bus_pin_base + 5);

src/main.c

@@ -8,8 +8,13 @@
 // Set the system frequency to 33 MHz x 6 to make time for handling LPC frames.
 #define SYS_FREQ_IN_KHZ (198 * 1000)
 
+// LAD[0-3] + LCLK + LFRAME, which starts from GPIO0.
+#define LPC_BUS_PIN_BASE (0U)
+#define LPC_BUS_PIN_COUNT (6U)
+
 // POST Code LEDs[0–8], which start from GPIO8.
 #define LED_POST_CODE_PIN_BASE (8U)
+#define LED_POST_CODE_PIN_COUNT (8U)
 
 #define LED_STATUS_PIN PICO_DEFAULT_LED_PIN
 #define INTERVAL_IM_ALIVE_MS (1000)
@@ -60,8 +65,6 @@ uint32_t reverse_nibbles(uint32_t in_val) {
 }
 
 int init_lpc_bus_sniffer(PIO pio) {
-    // LAD[0-3] + LCLK + LFRAME which starts from GPIO0
-    uint lpc_bus_pin_base = 0;
     uint offset;
 
     printf("initializing the lpc bus sniffer program\n");
@@ -79,7 +82,7 @@ int init_lpc_bus_sniffer(PIO pio) {
         return -2;
     }
 
-    lpc_bus_sniffer_program_init(pio, sm, offset, lpc_bus_pin_base, LED_POST_CODE_PIN_BASE);
+    lpc_bus_sniffer_program_init(pio, sm, offset, LPC_BUS_PIN_BASE, LPC_BUS_PIN_COUNT, LED_POST_CODE_PIN_BASE, LED_POST_CODE_PIN_COUNT);
     pio_sm_set_enabled(pio, sm, true);
 
     // Set the I/O RW frame filter