Skip to content

Change JavaScriptConverter to JsonConvert.DeserializeObject #47

@TypNull

Description

@TypNull

Subject: Request for Enhancements in CokyGrabber: .NET Core Support and Librewolf Integration

Hello,

I am reaching out regarding the functionality of CockyGrabber for extracting bookmarks from Librewolf (Gecko). I have encountered an issue with the current project's lack of support for .NET Core, as I intend to utilize it with .NET 6 or a higher version. Upon using your NuGet package, an error was triggered due to the absence of the file containing "System.Web.Script.Serialization;". To overcome this obstacle, I resorted to manually copying your source code and change it for my usage.

I am kindly requesting the following enhancements to enhance compatibility and functionality:

  1. Replace the JavascriptConverter with JsonConvert.DeserializeObject to facilitate support for dynamic JSON objects in .NET Core:
using Newtonsoft.Json;
dynamic json = JsonConvert.DeserializeObject(File.ReadAllText(profile + BookmarkPath));
  1. Incorporate Librewolf support in the UniversalGrabber feature of CockyGrabber:
public class LibrefoxGrabber : GeckoGrabber
{
    public override string ProfileDirPath => Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData) + "\\librewolf\\Profiles";
}
  1. I believe there may be an error in the documentation regarding the implementation of your own GeckoGrabber, where the base class should not be the BlinkGrabber:
    Link to documentation correction

Thank you for considering these requests.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions