some linter cleanups

Author: dshadowwolf

src/main/java/com/mcmoddev/orespawn/EventHandlers.java

@@ -140,9 +140,6 @@ private boolean compFeatures(NBTTagList tagList, int dim) {
 					.collect(Collectors.toList()));
 		}
 
-//		List<SpawnBuilder> spc = new LinkedList<>();
-//		spawns.stream().map( DimensionBuilder::getAllSpawns ).forEach( spc::addAll );
-		
 		List<FeatureBuilder> featureList = new LinkedList<>();
 
 		spawns.forEach( sp -> featureList.addAll(sp.getAllSpawns().stream().map( SpawnBuilder::getFeatureGen ).collect(Collectors.toList())));

src/main/java/com/mcmoddev/orespawn/api/FeatureBase.java

@@ -34,10 +34,6 @@ public FeatureBase( Random rand ) {
 		this.random = rand;
 	}
 
-	private String getBiomeName( Biome biome ) {
-		return ForgeRegistries.BIOMES.getKey( biome ).toString();
-	}
-
 	private boolean fullMatch( ImmutableSet<BiomeLocation> locs, Biome biome ) {
 		for( BiomeLocation b : locs ) {
 			for( Biome bm : b.getBiomes () ) {
@@ -85,8 +81,6 @@ protected boolean spawn( IBlockState oreBlock, World world, BlockPos coord, int
 			return false;
 		}
 
-		List<IBlockState> blockToReplace = blockReplace;
-
 		Biome thisBiome = world.getBiome ( coord );
 		if( biomeMatch ( thisBiome, biomes ) ) return false;
 
@@ -132,8 +126,6 @@ protected boolean spawnNoCheck( IBlockState oreBlock, World world, BlockPos coor
 			return false;
 		}
 
-		List<IBlockState> blockToReplace = blockReplace;
-
 		BlockPos np = mungeFixYcoord(coord);
 
 		if( coord.getY() >= world.getHeight()) {
@@ -217,5 +209,21 @@ protected static void mergeDefaults(JsonObject parameters, JsonObject defaultPar
 			if( !parameters.has(entry.getKey()) ) 
 				parameters.add(entry.getKey(), entry.getValue());
 		});
-	}	
+	}
+
+	protected double triangularDistribution(double a, double b, double c) {
+		double base = (c - a) / (b - a);
+		double rand = this.random.nextDouble();
+		if (rand < base) {
+			return a + Math.sqrt(rand * (b - a) * (c - a));
+		} else {
+			return b - Math.sqrt((1 - rand) * (b - a) * (b - c));
+		}
+	}
+
+	protected int getPoint( int lowerBound, int upperBound, int median ) {
+		int t = (int)Math.round( triangularDistribution((float)lowerBound, (float)upperBound, (float)median) );
+		return t - median;
+	}
+
 }

src/main/java/com/mcmoddev/orespawn/impl/features/ClusterGenerator.java

@@ -70,21 +70,6 @@ public void generate( ChunkPos pos, World world, IChunkGenerator chunkGenerator,
 		}
 	}
 
-	private double triangularDistribution(double a, double b, double c) {
-	    double base = (c - a) / (b - a);
-	    double rand = this.random.nextDouble();
-	    if (rand < base) {
-	        return a + Math.sqrt(rand * (b - a) * (c - a));
-	    } else {
-	        return b - Math.sqrt((1 - rand) * (b - a) * (b - c));
-	    }
-	}
-
-	private int getPoint( int lowerBound, int upperBound, int median ) {
-		int t = (int)Math.round( triangularDistribution((float)lowerBound, (float)upperBound, (float)median) );
-		return t - median;
-	}
-	
 	private enum parms {
 		SIZE, VARIANCE, CCOUNT, MAXSPREAD, MINHEIGHT, MAXHEIGHT
 	}

src/main/java/com/mcmoddev/orespawn/impl/features/NormalCloudGenerator.java

@@ -101,21 +101,6 @@ public void generate(ChunkPos pos, World world, IChunkGenerator chunkGenerator,
 		}
 	}
 
-	private double triangularDistribution(double a, double b, double c) {
-	    double base = (c - a) / (b - a);
-	    double rand = this.random.nextDouble();
-	    if (rand < base) {
-	        return a + Math.sqrt(rand * (b - a) * (c - a));
-	    } else {
-	        return b - Math.sqrt((1 - rand) * (b - a) * (b - c));
-	    }
-	}
-
-	private int getPoint( int lowerBound, int upperBound, int median ) {
-		int t = (int)Math.round( triangularDistribution((float)lowerBound, (float)upperBound, (float)median) );
-		return t - median;
-	}
-	
 	private enum parms {
 		SIZE, MAXSPREAD, MINHEIGHT, MAXHEIGHT
 	}

src/main/java/com/mcmoddev/orespawn/worldgen/OreSpawnWorldGen.java

@@ -1,10 +1,6 @@
 package com.mcmoddev.orespawn.worldgen;
 
-import java.util.List;
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.Map;
-import java.util.Random;
+import java.util.*;
 import java.util.stream.Collectors;
 
 import com.google.common.collect.ImmutableList;
@@ -79,7 +75,7 @@ public void generate(Random random, int chunkX, int chunkZ, World world, IChunkG
 			currentFeatureGen.setRandom(random);
 			currentFeatureGen.generate(new ChunkPos(chunkX, chunkZ), world, chunkGenerator, chunkProvider, sE.getFeatureGen().getParameters(), sE.getOreSpawns(), replacement, sE.getBiomes());
 		});
-	}	
+	}
 }