Skip to content

Commit 471e48a

Browse files
set min-max flow rate to 0 in units (#287)
* set min-max flow rate to 0 in units Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech> * Update CHANGELOG.md Signed-off-by: pepmts <pierre-elie.personnaz@metroscope.tech>
1 parent 986a9c9 commit 471e48a

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
88
## [Unreleased]
99

1010
### Fixed <!--Make sure to add a link to the PR and issues related to your change-->
11+
- Fixed [#282](https://github.com/Metroscope-dev/metroscope-modeling-library/issues/282) with [#287](https://github.com/Metroscope-dev/metroscope-modeling-library/issues/287), by setting min and max in Positive/Negative MassFlowRate to 0, as it was an unnecessary protection.
1112
- Fixed [#273](https://github.com/Metroscope-dev/metroscope-modeling-library/issues/273), steam extraction splitter'`x` are lower than 1 [PR#275](https://github.com/Metroscope-dev/metroscope-modeling-library/pull/275)
1213
- Fixed `IsoHFlowModel` and `IsoPHFlowModel` now use `h_0` as `h` start value with [PR #265]([url](https://github.com/Metroscope-dev/metroscope-modeling-library/pull/265))
1314
- Fixed `NTU HX` test configuration name for `shell_and_tubes` test, [PR #239](https://github.com/Metroscope-dev/metroscope-modeling-library/pull/239)
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
within MetroscopeModelingLibrary.Units;
2-
type NegativeMassFlowRate=SI.MassFlowRate(max=-1e-5, start=-1e3, nominal=-1e3);
2+
type NegativeMassFlowRate=SI.MassFlowRate(max=0, start=-1e3, nominal=-1e3);
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
within MetroscopeModelingLibrary.Units;
2-
type PositiveMassFlowRate =
3-
SI.MassFlowRate(min=1e-5, start=1e3, nominal=1e3);
2+
type PositiveMassFlowRate = SI.MassFlowRate(min=0, start=1e3, nominal=1e3);

0 commit comments

Comments
 (0)